From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] Deduplicate the actual base page size code
Date: Wed, 11 May 2016 07:15:39 +0530 [thread overview]
Message-ID: <87vb2liczg.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <8def36ee-f94f-8d31-da87-dfe896df4df4@gmail.com>
Balbir Singh <bsingharora@gmail.com> writes:
> On 11/05/16 04:09, Aneesh Kumar K.V wrote:
>> Balbir Singh <bsingharora@gmail.com> writes:
>>
>>> Deduplicate to one function to compute the actual page size.
>>> Some additional warnings added for AP size as well.
>>
>>
>> This is getting chaned in a cleanup series I am testing before posting.
>> The change from ap to psize need more update in commit message.
>>
>> commit 701e0d3dc33c93a97b825f403d58f6be99b89203
>> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Date: Tue May 10 11:33:15 2016 +0530
>>
>> powerpc/mm/radix/hugetlb: Add helper for finding page size from hstate
>>
>> Use the helper instead of open coding the same at multiple place
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> This version makes more sense. While we are at it, mind replacing psize with base_psize and asserting
> that base_psize is always 0 or 5.
>
With radix config there is no base/actual page size. The new function is
returning MMU_PAGE_* values and not the AP encoding.
-aneesh
prev parent reply other threads:[~2016-05-11 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 14:57 [v1] Basic Radix Tree cleanups Balbir Singh
2016-05-10 14:57 ` [PATCH 1/2] Fix .long's in mm/tlb-radix.c to more meaningful Balbir Singh
2016-05-10 18:12 ` Aneesh Kumar K.V
2016-05-10 14:57 ` [PATCH 2/2] Deduplicate the actual base page size code Balbir Singh
2016-05-10 18:09 ` Aneesh Kumar K.V
2016-05-11 1:18 ` Balbir Singh
2016-05-11 1:45 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb2liczg.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.