From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1atZbA-0006Bz-It
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 07:50:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1atZb9-0003Sk-Px
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 07:50:12 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1461320695-31372-1-git-send-email-berrange@redhat.com>
	<1461320695-31372-2-git-send-email-berrange@redhat.com>
	<20160422105928.GC4237@noname.redhat.com>
Date: Fri, 22 Apr 2016 13:50:04 +0200
In-Reply-To: <20160422105928.GC4237@noname.redhat.com> (Kevin Wolf's message
	of "Fri, 22 Apr 2016 12:59:28 +0200")
Message-ID: <87vb39q2vn.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to
 match -drive with -iscsi opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, Pino Toscano <ptoscano@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, John Ferlan <jferlan@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Kevin Wolf <kwolf@redhat.com> writes:

> Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben:
>> The iSCSI block driver has ability to lookup various options, in
>> particular authentication info, specified by the separate -iscsi
>> argument. It currently uses the iSCSI IQN as the ID value for this
>> lookup, however, this does not work for common iSCSI IQNs as they
>> contain characters such as ':' which are invalid for use as IDs.
>> 
>> This adds an optional 'iscsi-id' parameter to the iSCSI block
>> driver to allow an explicit ID string to be used to reference
>> the -iscsi arg. For example
>> 
>>  $QEMU \
>>    -iscsi id=my_initiator,user=fred,password-secret=sec0 \
>>    -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1
>> 
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

This patch is cleaner and safer than "block: convert iscsi target to a
valid ID for -iscsi arg lookup".

> I would consider this a new feature rather than a fix appropriate for
> -rc4.

I'd be willing to spin this as a fix for a design bug, but I agree with
Kevin, it missed the boat.  I might have supported it up until rc1 or
so.