From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as9k2-0002PJ-SH for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1as9k0-00007s-5P for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:01:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as9jz-00007h-Vt for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:01:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5649462655 for ; Mon, 18 Apr 2016 14:01:27 +0000 (UTC) From: Markus Armbruster References: <1460147350-7601-1-git-send-email-pbonzini@redhat.com> <1460147350-7601-50-git-send-email-pbonzini@redhat.com> Date: Mon, 18 Apr 2016 16:01:25 +0200 In-Reply-To: <1460147350-7601-50-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Fri, 8 Apr 2016 22:29:09 +0200") Message-ID: <87vb3faudm.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini writes: > pio_addr_t is almost unused, because these days I/O ports are simply > accessed through the address space. cpu_{in,out}[bwl] themselves are > almost unused; monitor.c and xen-hvm.c could use address_space_read/write > directly, since they have an integer size at hand. This leaves qtest as > the only user of those functions. > > Not the other hand even portio_* functions use this type; the only On the other hand? > interesting use of pio_addr_t thus is include/hw/sysbus.h. I guess I > could move it there, but I don't see much benefit in that either. Using > uint32_t is enough and avoids the need to include ioport.h everywhere. > > Signed-off-by: Paolo Bonzini