All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tools/intel_reg: Fix builtin register	spec for gen4
Date: Tue, 05 Apr 2016 16:50:59 +0300	[thread overview]
Message-ID: <87vb3wtb98.fsf@intel.com> (raw)
In-Reply-To: <1459858383-17768-1-git-send-email-ville.syrjala@linux.intel.com>

On Tue, 05 Apr 2016, ville.syrjala@linux.intel.com wrote:
> [ text/plain ]
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Actually use the builtin register spec on gen4. Makes intel_reg dump
> actually do something on gen4.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  tools/intel_reg_decode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/intel_reg_decode.c b/tools/intel_reg_decode.c
> index bb8f5b30311f..470fecc165c6 100644
> --- a/tools/intel_reg_decode.c
> +++ b/tools/intel_reg_decode.c
> @@ -2580,7 +2580,7 @@ static bool is_945gm(uint32_t devid, uint32_t pch)
>  
>  static bool is_gen234(uint32_t devid, uint32_t pch)
>  {
> -	return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN3(devid);
> +	return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN4(devid);

Facepalm-by: Jani Nikula <jani.nikula@intel.com>


>  }
>  
>  #define DECLARE_REGS(d,r,m)				\

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2016-04-05 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 12:13 [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4 ville.syrjala
2016-04-05 12:17 ` Matthew Auld
2016-04-05 13:50 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb3wtb98.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.