From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrnx-0008AZ-4h for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afrnu-0000k4-Ff for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:26:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrnu-0000jm-93 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:26:42 -0400 From: Markus Armbruster References: <1458054221-16923-1-git-send-email-armbru@redhat.com> <1458054221-16923-2-git-send-email-armbru@redhat.com> <56E8327B.1090002@redhat.com> Date: Tue, 15 Mar 2016 17:26:39 +0100 In-Reply-To: <56E8327B.1090002@redhat.com> (Paolo Bonzini's message of "Tue, 15 Mar 2016 17:04:11 +0100") Message-ID: <87vb4nso5c.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Paolo Bonzini writes: > On 15/03/2016 16:03, Markus Armbruster wrote: >> diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h >> index 2dabe49..904501a 100644 >> --- a/include/ui/qemu-spice.h >> +++ b/include/ui/qemu-spice.h >> @@ -23,6 +23,7 @@ >> >> #include >> >> +#include "qapi/error.h" >> #include "qemu/option.h" >> #include "qemu/config-file.h" >> > > This must be moved outside the #ifdef CONFIG_SPICE, because > ui/qemu-spice.h uses error_set call outside that #ifdef. Oops! The inline function seems ill-advised to me, but let's avoid patch series creep. I'll fix it the way you described.