From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix hpd live status bits for g4x Date: Fri, 12 Feb 2016 08:26:27 +0200 Message-ID: <87vb5uqwa4.fsf@intel.com> References: <1455127145-20087-1-git-send-email-ville.syrjala@linux.intel.com> <20160211100358.GR11240@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160211100358.GR11240@phenom.ffwll.local> Sender: stable-owner@vger.kernel.org To: Daniel Vetter , ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, Shashank Sharma , Sonika Jindal , Daniel Vetter , Nick Bowler , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 11 Feb 2016, Daniel Vetter wrote: > On Wed, Feb 10, 2016 at 07:59:05PM +0200, ville.syrjala@linux.intel.c= om wrote: >> From: Ville Syrj=C3=A4l=C3=A4 >>=20 >> Looks like g4x hpd live status bits actually agree with the spec. At >> least they do on the machine I have, and apparently on Nick Bowler's >> g4x as well. >>=20 >> So gm45 may be the only platform where they don't agree. At least >> that seems to be the case based on the (somewhat incomplete) >> logs/dumps in [1], and Daniel has also tested this on his gm45 >> sometime in the past. >>=20 >> So let's change the bits to match the spec on g4x. That actually mak= es >> the g4x bits identical to vlv/chv so we can just share the code >> between those platforms, leaving gm45 as the special case. >>=20 >> [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D52361 >>=20 >> Cc: Shashank Sharma >> Cc: Sonika Jindal >> Cc: Daniel Vetter >> Cc: Jani Nikula >> Cc: Nick Bowler >> References: https://lists.freedesktop.org/archives/dri-devel/2016-Fe= bruary/100382.html >> Reported-by: Nick Bowler >> Cc: stable@vger.kernel.org >> Fixes: 237ed86c693d ("drm/i915: Check live status before reading edi= d") >> Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > > Yeah I'm hopeful this will work. Reviewed-by: Daniel Vetter > > Since CI is down and this is super restricted impact and fixing a > regression I'm voting that we'll pick it up right away. Jani, are you= ok > with that? Ack. > -Daniel > >> --- >> drivers/gpu/drm/i915/i915_reg.h | 15 ++++++++------- >> drivers/gpu/drm/i915/intel_dp.c | 14 +++++++------- >> 2 files changed, 15 insertions(+), 14 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/= i915_reg.h >> index 188ad5de020f..678faa957e75 100644 >> --- a/drivers/gpu/drm/i915/i915_reg.h >> +++ b/drivers/gpu/drm/i915/i915_reg.h >> @@ -3296,19 +3296,20 @@ enum skl_disp_power_wells { >> =20 >> #define PORT_HOTPLUG_STAT _MMIO(dev_priv->info.display_mmio_offset = + 0x61114) >> /* >> - * HDMI/DP bits are gen4+ >> + * HDMI/DP bits are g4x+ >> * >> * WARNING: Bspec for hpd status bits on gen4 seems to be completel= y confused. >> * Please check the detailed lore in the commit message for for exp= erimental >> * evidence. >> */ >> -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) >> +/* Bspec says GM45 should match G4X/VLV/CHV, but reality disagrees = */ >> +#define PORTD_HOTPLUG_LIVE_STATUS_GM45 (1 << 29) >> +#define PORTC_HOTPLUG_LIVE_STATUS_GM45 (1 << 28) >> +#define PORTB_HOTPLUG_LIVE_STATUS_GM45 (1 << 27) >> +/* G4X/VLV/CHV DP/HDMI bits again match Bspec */ >> +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) >> #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) >> -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) >> -/* VLV DP/HDMI bits again match Bspec */ >> -#define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) >> -#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28) >> -#define PORTB_HOTPLUG_LIVE_STATUS_VLV (1 << 29) >> +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) >> #define PORTD_HOTPLUG_INT_STATUS (3 << 21) >> #define PORTD_HOTPLUG_INT_LONG_PULSE (2 << 21) >> #define PORTD_HOTPLUG_INT_SHORT_PULSE (1 << 21) >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/= intel_dp.c >> index a073f04a5330..bbe18996efe6 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -4490,20 +4490,20 @@ static bool g4x_digital_port_connected(struc= t drm_i915_private *dev_priv, >> return I915_READ(PORT_HOTPLUG_STAT) & bit; >> } >> =20 >> -static bool vlv_digital_port_connected(struct drm_i915_private *dev= _priv, >> - struct intel_digital_port *port) >> +static bool gm45_digital_port_connected(struct drm_i915_private *de= v_priv, >> + struct intel_digital_port *port) >> { >> u32 bit; >> =20 >> switch (port->port) { >> case PORT_B: >> - bit =3D PORTB_HOTPLUG_LIVE_STATUS_VLV; >> + bit =3D PORTB_HOTPLUG_LIVE_STATUS_GM45; >> break; >> case PORT_C: >> - bit =3D PORTC_HOTPLUG_LIVE_STATUS_VLV; >> + bit =3D PORTC_HOTPLUG_LIVE_STATUS_GM45; >> break; >> case PORT_D: >> - bit =3D PORTD_HOTPLUG_LIVE_STATUS_VLV; >> + bit =3D PORTD_HOTPLUG_LIVE_STATUS_GM45; >> break; >> default: >> MISSING_CASE(port->port); >> @@ -4555,8 +4555,8 @@ bool intel_digital_port_connected(struct drm_i= 915_private *dev_priv, >> return cpt_digital_port_connected(dev_priv, port); >> else if (IS_BROXTON(dev_priv)) >> return bxt_digital_port_connected(dev_priv, port); >> - else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) >> - return vlv_digital_port_connected(dev_priv, port); >> + else if (IS_GM45(dev_priv)) >> + return gm45_digital_port_connected(dev_priv, port); >> else >> return g4x_digital_port_connected(dev_priv, port); >> } >> --=20 >> 2.4.10 >>=20 --=20 Jani Nikula, Intel Open Source Technology Center