From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQb8V-0008Kx-RA for qemu-devel@nongnu.org; Tue, 02 Feb 2016 08:36:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQb8R-0005hY-WC for qemu-devel@nongnu.org; Tue, 02 Feb 2016 08:36:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQb8R-0005hU-Qp for qemu-devel@nongnu.org; Tue, 02 Feb 2016 08:36:47 -0500 From: Markus Armbruster References: <1453804885-15544-1-git-send-email-kraxel@redhat.com> <1453804885-15544-4-git-send-email-kraxel@redhat.com> Date: Tue, 02 Feb 2016 14:36:45 +0100 In-Reply-To: <1453804885-15544-4-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Tue, 26 Jan 2016 11:41:24 +0100") Message-ID: <87vb67kzde.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, =?utf-8?Q?Andreas_F=C3=A4rber?= Gerd Hoffmann writes: > This patch marks usb-bot as hot-pluggable device, makes attached > property settable and turns off auto-attach in case the device > was hotplugged. > > Hot-plugging a usb-bot device with one or more scsi devices can be > done this way now: > > (1) device-add usb-bot,id=foo > (2) device-add scsi-{hd,cd},bus=foo.0,lun=0 > (2b) optionally add more devices (luns 0 ... 15). > (3) qom-set foo.attached = true This isn't exactly pretty, but it beats no hot plug. A general solution for hot plugging composite devices could perhaps be prettier, but I'm not aware of any recent work in the area. Andreas, Paolo? > Signed-off-by: Gerd Hoffmann Assuming we want this because we can't have a general solution now: Reviewed-by: Markus Armbruster