From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756617AbcARUfv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jan 2016 15:35:51 -0500
Received: from mail-wm0-f47.google.com ([74.125.82.47]:34232 "EHLO
	mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756071AbcARUfs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jan 2016 15:35:48 -0500
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Robert Elliott <elliott@hpe.com>, Matt Fleming <matt@codeblueprint.co.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        Brian Norris <computersforpeace@gmail.com>,
        Hariprasad S <hariprasad@chelsio.com>
Subject: Re: [PATCH v2 01/11] lib/vsprintf: introduce put_one_char() for 3 line idiom
Organization: D03
References: <1452810221-116505-1-git-send-email-andriy.shevchenko@linux.intel.com>
	<1452810221-116505-2-git-send-email-andriy.shevchenko@linux.intel.com>
X-Hashcash: 1:20:160118:computersforpeace@gmail.com::tKqBLz/kwXBvakxj:00000000000000000000000000000000000Q5G
X-Hashcash: 1:20:160118:linux-kernel@vger.kernel.org::g/OCGefBgQrtqs0d:0000000000000000000000000000000000FIX
X-Hashcash: 1:20:160118:hpa@zytor.com::WZcbuHQ7laPf5TvZ:00001ToI
X-Hashcash: 1:20:160118:hariprasad@chelsio.com::FByxMVH3uCnllgs3:0000000000000000000000000000000000000001Ckd
X-Hashcash: 1:20:160118:matt@codeblueprint.co.uk::LAuGLv3R6gGlkFHV:00000000000000000000000000000000000001vLP
X-Hashcash: 1:20:160118:tglx@linutronix.de::qBm/2zBPAx157NcU:000000000000000000000000000000000000000000022DC
X-Hashcash: 1:20:160118:andriy.shevchenko@linux.intel.com::Eyot7sD9jrowiP/J:000000000000000000000000000056eC
X-Hashcash: 1:20:160118:mingo@redhat.com::e5Mp7DHy02Imqk68:05cFp
X-Hashcash: 1:20:160118:akpm@linux-foundation.org::dNNlj3mG6ev6F3a1:0000000000000000000000000000000000006w2T
X-Hashcash: 1:20:160118:elliott@hpe.com::w+60vDXyIB0sbmQr:00I3+N
Date: Mon, 18 Jan 2016 21:35:42 +0100
In-Reply-To: <1452810221-116505-2-git-send-email-andriy.shevchenko@linux.intel.com>
	(Andy Shevchenko's message of "Fri, 15 Jan 2016 00:23:31 +0200")
Message-ID: <87vb6qeich.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 14 2016, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> There is an idiom used widely in the code
>
> 	if (buf < end)
> 		*buf = c;
> 	++buf;
>
> Introduce put_one_char() helper as implementation of this idiom.
>

I suppose it does make the code a little more readable, but the current
idiom isn't that bad. Does it affect the generated code, and if so, does
it become smaller/larger, faster/slower?

Rasmus