From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Kko-00057Q-W3 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Kkl-0007b5-NB for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:28:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Kkl-0007az-IG for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:28:11 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 2ED75688 for ; Mon, 30 Nov 2015 09:28:11 +0000 (UTC) From: Markus Armbruster References: <20151130034732.GA12255@pxdev.xzpeter.org> <565C12EA.5090801@redhat.com> Date: Mon, 30 Nov 2015 10:28:08 +0100 In-Reply-To: <565C12EA.5090801@redhat.com> (Paolo Bonzini's message of "Mon, 30 Nov 2015 10:12:10 +0100") Message-ID: <87vb8jbzvb.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] question: about exec/poison.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Peter Xu Paolo Bonzini writes: > On 30/11/2015 04:47, Peter Xu wrote: >> >> I met one problem when trying to add a new public function in dump.h >> named "dump_state_get_global" and using it in hmp.c. > > Don't do that. :) > > hmp.c functions should in general use the QMP commands as the base. In > your case, hmp_info_dump should call qmp_query_dump. Yes. HMP commands need to be implemented on top of QMP commands, to avoid a feature gap. Exception: HMP commands that make no sense for QMP, like "print" or "cpu".