From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755223AbbJHKYy (ORCPT <rfc822;w@1wt.eu>);
	Thu, 8 Oct 2015 06:24:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60638 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753949AbbJHKYw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 8 Oct 2015 06:24:52 -0400
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
        jasowang@redhat.com, Jake Oshins <jakeo@microsoft.com>
Subject: Re: [PATCH 10/10] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through
References: <1444269571-25217-1-git-send-email-kys@microsoft.com>
	<1444269709-25270-1-git-send-email-kys@microsoft.com>
	<1444269709-25270-10-git-send-email-kys@microsoft.com>
Date: Thu, 08 Oct 2015 12:24:48 +0200
In-Reply-To: <1444269709-25270-10-git-send-email-kys@microsoft.com>
	(K. Y. Srinivasan's message of "Wed, 7 Oct 2015 19:01:49 -0700")
Message-ID: <87vbahejyn.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"K. Y. Srinivasan" <kys@microsoft.com> writes:

> From: Jake Oshins <jakeo@microsoft.com>
>
> This defines the channel type for PCI front-ends in Hyper-V VMs.
>
> Signed-off-by: Jake Oshins <jakeo@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/hv/channel_mgmt.c |    3 +++
>  include/linux/hyperv.h    |   11 +++++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 652afd1..1ae615b 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -358,6 +358,7 @@ enum {
>  	SCSI,
>  	NIC,
>  	ND_NIC,
> +	HV_PCIE,
>  	MAX_PERF_CHN,
>  };

It seems all other members of the enum don't have HV_ prefix... should
we add it there or remove it from HV_PCIE?

>
> @@ -375,6 +376,8 @@ static const struct hv_vmbus_device_id hp_devs[] = {
>  	{ HV_NIC_GUID, },
>  	/* NetworkDirect Guest RDMA */
>  	{ HV_ND_GUID, },
> +	/* PCI Express Pass Through */
> +	{ HV_PCIE_GUID, },
>  };

And here everything is prefixed with HV_ ... so I'd say we add HV_ to
all members of the previously mentioned enum.

[...]

-- 
  Vitaly