From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH RFCv2 3/4] staging: etnaviv: add drm driver
Date: Wed, 16 Sep 2015 14:43:46 -0400
Message-ID: <87vbba9pct.fsf@eliezer.anholt.net>
References: <1441980614-19216-1-git-send-email-l.stach@pengutronix.de>
 <1441980614-19216-4-git-send-email-l.stach@pengutronix.de>
 <871tdy2ymw.fsf@eliezer.anholt.net>
 <20150916165122.GE21084@n2100.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1972203085=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20150916165122.GE21084@n2100.arm.linux.org.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============1972203085==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> On Wed, Sep 16, 2015 at 11:05:11AM -0400, Eric Anholt wrote:
>> Lucas Stach <l.stach@pengutronix.de> writes:
>>=20
>> > From: Christian Gmeiner <christian.gmeiner@gmail.com>
>>=20
>> > +static bool etnaviv_validate_load_state(struct etnaviv_gpu *gpu, u32 =
*buf,
>> > +	unsigned int state, unsigned int num)
>> > +{
>> > +	return true;
> ...
>> > +}
>>=20
>> I was browsing the code, and noticed that it looks like you've got a
>> debugging early return in your validation function here.
>
> That's because it's not quite ready to be enabled yet - the code as
> it stands in my tree doesn't have the infrastructure to validate that
> a LOADSTATE which touches an address register (or similar) has a
> relocation appropriately marked, due to the way things happen.
> Hopefully, when the user/kernel API is sorted, this can be resolved.

OK.  Validation code is painful to write, so I was just browsing what
was in here to see if I could pick up anything useful.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJV+bhiAAoJELXWKTbR/J7oIxUQAK9oBYLUkWsSdPsVds1XHXJx
HdTQSOEDCXXcP9d3+rp1a+RQAbKMclZEC/JPoO5okmfJiax0Fb5jgkd3IiE2xqUB
TwNpDDX142bHOmACnc10rNIaCdyUqY0D0S7vS6wiWG50FHh2CCNNg1DD64B0vlLn
OAlR+BZ4Wyo3IFBdMpkrIc4NK+KPpw1TssUoJVwCFPsnhm+DoWLRRM7VRPDwjDD4
v+MDku30tu9o74KAs9TSs08IXf/gqloYkqBQPWHtavRtsTYRY9v1hfBgdoaRMWu4
01PI0WPWq/DuydcBXy0MgtMTdBc1294fipQmtT4LcNOTqoKgA7gi16+NYfttGHcq
LAodxzWmrt8aMgS1HtJ5YpEP4kxVTj5fA0XChe23GB1vLGJIPEVH/7+YrmNIbd98
2gKlsNiKvYYfqOGQBDv3yWKVYbvlnqidkD6ZstalirpVb0cUMM3BlxY8RGf/3muy
x6/rChzSkp0JJXquBKkO217xrygoTCIEd7sxGbQjZSYpdXsJLZTs2gwM+ciduLS4
9ocTh+5DWPRPwgAJC4PEsnc0/DsWkQbijYDr6qLwwrwBtjjFA+3wzd1wq2uYCCzR
4PAnSGheYdHCV/adiI0fa7WoCJjWmRYrIxbxThl38Uw9P88CggVF8724uH9sKMi5
CVvVIHJz58PzYfuTJeyf
=+NQn
-----END PGP SIGNATURE-----
--=-=-=--

--===============1972203085==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============1972203085==--