From: Kalle Valo <kvalo@codeaurora.org>
To: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH 08/13] wil6210: hold wil->mutex while managing vrings
Date: Fri, 24 Jul 2015 17:41:36 +0300 [thread overview]
Message-ID: <87vbd9d3dr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1436081080-27305-9-git-send-email-qca_vkondrat@qca.qualcomm.com> (Vladimir Kondratiev's message of "Sun, 5 Jul 2015 10:24:35 +0300")
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes:
> To prevent race when connect flow may run in parallel with
> the disconnect event.
>
> Scenario leading to the bug is: while running connect flow on the AP,
> STA sends disconnect. log follows.
[...]
> --- a/drivers/net/wireless/ath/wil6210/txrx.c
> +++ b/drivers/net/wireless/ath/wil6210/txrx.c
> @@ -160,6 +160,7 @@ static void wil_vring_free(struct wil6210_priv *wil, struct vring *vring,
> struct device *dev = wil_to_dev(wil);
> size_t sz = vring->size * sizeof(vring->va[0]);
>
> + WARN_ON(!mutex_is_locked(&wil->mutex));
lockdep_assert_held() is supposed to be used for verifying locking, see
ath10k for examples.
--
Kalle Valo
next prev parent reply other threads:[~2015-07-24 14:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 7:24 [PATCH 00/13] wil6210 patches Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 01/13] wil6210: support boot loader struct v0 & v1 Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 02/13] wil6210: ACS implementation using QCA vendor command Vladimir Kondratiev
2015-07-05 10:35 ` Johannes Berg
2015-07-07 13:22 ` Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 03/13] wil6210: debugfs for channel survey Vladimir Kondratiev
2015-07-24 14:38 ` Kalle Valo
2015-07-05 7:24 ` [PATCH 04/13] wil6210: count drops in Rx block ack reorder Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 05/13] wil6210: print "ulong" fields in hex format in the debugfs Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 06/13] wil6210: use <> vs. "" for global include Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 07/13] wil6210: wait for del_station to complete Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 08/13] wil6210: hold wil->mutex while managing vrings Vladimir Kondratiev
2015-07-24 14:41 ` Kalle Valo [this message]
2015-07-05 7:24 ` [PATCH 09/13] wil6210: use wil_fw_error_recovery() Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 10/13] wil6210: skip HW version check for chip debugging Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 11/13] wil6210: TSO implementation Vladimir Kondratiev
2015-07-08 19:06 ` Emmanuel Grumbach
2015-07-09 11:37 ` Vladimir Kondratiev
2015-07-09 12:36 ` Emmanuel Grumbach
2015-07-21 14:20 ` Kalle Valo
2015-07-05 7:24 ` [PATCH 12/13] wil6210: improve mgmt frame handling Vladimir Kondratiev
2015-07-05 7:24 ` [PATCH 13/13] wil6210: treat "unhandled event" as warning instead of error Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 00/13] wil6210 patches Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 01/13] wil6210: support boot loader struct v0 & v1 Vladimir Kondratiev
2015-07-24 14:19 ` Kalle Valo
2015-07-06 7:39 ` [PATCH v2 02/13] wil6210: ACS implementation using QCA vendor command Vladimir Kondratiev
2015-07-24 14:22 ` Kalle Valo
2015-07-06 7:39 ` [PATCH v2 03/13] wil6210: debugfs for channel survey Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 04/13] wil6210: count drops in Rx block ack reorder Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 05/13] wil6210: print "ulong" fields in hex format in the debugfs Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 06/13] wil6210: use <> vs. "" for global include Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 07/13] wil6210: wait for del_station to complete Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 08/13] wil6210: hold wil->mutex while managing vrings Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 09/13] wil6210: use wil_fw_error_recovery() Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 10/13] wil6210: skip HW version check for chip debugging Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 11/13] wil6210: TSO implementation Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 12/13] wil6210: improve mgmt frame handling Vladimir Kondratiev
2015-07-06 7:39 ` [PATCH v2 13/13] wil6210: treat "unhandled event" as warning instead of error Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbd9d3dr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.