From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z820l-00087M-Gz for qemu-devel@nongnu.org; Thu, 25 Jun 2015 03:55:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z820h-00041K-1H for qemu-devel@nongnu.org; Thu, 25 Jun 2015 03:55:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z820g-00041D-Qc for qemu-devel@nongnu.org; Thu, 25 Jun 2015 03:55:46 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 5934F19F26A for ; Thu, 25 Jun 2015 07:55:46 +0000 (UTC) From: Markus Armbruster References: <1435078724-27104-1-git-send-email-lersek@redhat.com> Date: Thu, 25 Jun 2015 09:55:44 +0200 In-Reply-To: <1435078724-27104-1-git-send-email-lersek@redhat.com> (Laszlo Ersek's message of "Tue, 23 Jun 2015 18:58:41 +0200") Message-ID: <87vbec2pdr.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/3] update CMOS for ISA-FDC with iobase=0x3f0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Jan Tomko , John Snow , qemu-devel@nongnu.org, Paolo Bonzini Laszlo Ersek writes: > This is (again) for the other pc-q35-2.4 ISA-FDC problem reported by > Jan. Addressing comments from Markus. > > Jan, can you give it another try please? I realize this is getting old > pretty quick, so don't bother if you don't want to. > > Cc: Jan Tomko > Cc: John Snow > Cc: Markus Armbruster > Cc: Paolo Bonzini > > Thanks > Laszlo > > Laszlo Ersek (3): > hw/i386/pc: factor out pc_cmos_init_floppy() > hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS > hw/i386/pc: don't carry FDC from pc_basic_device_init() to > pc_cmos_init() > > include/hw/i386/pc.h | 3 +- > hw/i386/pc.c | 129 ++++++++++++++++++++++++++++++++++++++------------- > hw/i386/pc_piix.c | 5 +- > hw/i386/pc_q35.c | 5 +- > 4 files changed, 101 insertions(+), 41 deletions(-) Matter-of-taste comments on PATCH 3. Regardless: Reviewed-by: Markus Armbruster