From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors Date: Mon, 08 Jun 2015 13:50:23 +0300 Message-ID: <87vbey8oeo.fsf@intel.com> References: <20150607043253.12f4058e@mir> <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id B9D6D6E230 for ; Mon, 8 Jun 2015 03:53:08 -0700 (PDT) In-Reply-To: <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: ville.syrjala@linux.intel.com Cc: Ander Conselvan de Oliveira , nkalkhof@web.de, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stefan Lippers-Hollmann , torvalds@linux-foundation.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwOCBKdW4gMjAxNSwgQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5j b25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPiB3cm90ZToKPiBJbiB0aGUgY29tbWl0IGJl bG93LCBJIG1pc3NlZCB0aGUgY29ubmVjdG9yIGFsbG9jYXRpb24gaW4gdGhlIGZ1bmN0aW9uCj4g aW50ZWxfc2R2b19hbmFsb2dfaW5pdCgpLCBsZWFkaW5nIHRvIHRob3NlIGNvbm5lY3RvcnMgdG8g aGF2ZSBhIE5VTEwKPiBzdGF0ZSBwb2ludGVyLgo+Cj4gY29tbWl0IDA4ZDliYzkyMGQ0NjViYmJi ZDc2MmNhYzkzODMyNDljMTliZjY5YTIKPiBBdXRob3I6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2 ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiBEYXRlOiAgIEZy aSBBcHIgMTAgMTA6NTk6MTAgMjAxNSArMDMwMAo+Cj4gICAgIGRybS9pOTE1OiBBbGxvY2F0ZSBj b25uZWN0b3Igc3RhdGUgdG9nZXRoZXIgd2l0aCB0aGUgY29ubmVjdG9ycwo+Cj4gU2lnbmVkLW9m Zi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xp dmVpcmFAaW50ZWwuY29tPgoKUHVzaGVkIHRvIGRybS1pbnRlbC1maXhlcywgdGhhbmtzIGZvciB0 aGUgcGF0Y2ggYW5kIHRlc3RpbmcuCgpCUiwKSmFuaS4KCgoKPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2R2by5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9zZHZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBpbmRl eCBkMjRlZjc1Li5hYTJmZDc1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Nkdm8uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+IEBA IC0yNTU0LDcgKzI1NTQsNyBAQCBpbnRlbF9zZHZvX2FuYWxvZ19pbml0KHN0cnVjdCBpbnRlbF9z ZHZvICppbnRlbF9zZHZvLCBpbnQgZGV2aWNlKQo+ICAKPiAgCURSTV9ERUJVR19LTVMoImluaXRp YWxpc2luZyBhbmFsb2cgZGV2aWNlICVkXG4iLCBkZXZpY2UpOwo+ICAKPiAtCWludGVsX3Nkdm9f Y29ubmVjdG9yID0ga3phbGxvYyhzaXplb2YoKmludGVsX3Nkdm9fY29ubmVjdG9yKSwgR0ZQX0tF Uk5FTCk7Cj4gKwlpbnRlbF9zZHZvX2Nvbm5lY3RvciA9IGludGVsX3Nkdm9fY29ubmVjdG9yX2Fs bG9jKCk7Cj4gIAlpZiAoIWludGVsX3Nkdm9fY29ubmVjdG9yKQo+ICAJCXJldHVybiBmYWxzZTsK PiAgCj4gLS0gCj4gMi4xLjAKPgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbFHKxU (ORCPT ); Mon, 8 Jun 2015 06:53:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:19004 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbbFHKxM (ORCPT ); Mon, 8 Jun 2015 06:53:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,573,1427785200"; d="scan'208";a="739319860" From: Jani Nikula To: Ander Conselvan de Oliveira , ville.syrjala@linux.intel.com Cc: nkalkhof@web.de, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, torvalds@linux-foundation.org, Ander Conselvan de Oliveira , Stefan Lippers-Hollmann Subject: Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors In-Reply-To: <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20150607043253.12f4058e@mir> <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 08 Jun 2015 13:50:23 +0300 Message-ID: <87vbey8oeo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 Jun 2015, Ander Conselvan de Oliveira wrote: > In the commit below, I missed the connector allocation in the function > intel_sdvo_analog_init(), leading to those connectors to have a NULL > state pointer. > > commit 08d9bc920d465bbbbd762cac9383249c19bf69a2 > Author: Ander Conselvan de Oliveira > Date: Fri Apr 10 10:59:10 2015 +0300 > > drm/i915: Allocate connector state together with the connectors > > Signed-off-by: Ander Conselvan de Oliveira Pushed to drm-intel-fixes, thanks for the patch and testing. BR, Jani. > --- > drivers/gpu/drm/i915/intel_sdvo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index d24ef75..aa2fd75 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) > > DRM_DEBUG_KMS("initialising analog device %d\n", device); > > - intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); > + intel_sdvo_connector = intel_sdvo_connector_alloc(); > if (!intel_sdvo_connector) > return false; > > -- > 2.1.0 > -- Jani Nikula, Intel Open Source Technology Center