From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yzh8B-0008Iy-K8 for mharc-qemu-trivial@gnu.org; Tue, 02 Jun 2015 04:01:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzh84-0008EP-Hk for qemu-trivial@nongnu.org; Tue, 02 Jun 2015 04:01:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzh80-0008TQ-Dh for qemu-trivial@nongnu.org; Tue, 02 Jun 2015 04:00:56 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:50366 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzh7v-0008Qt-Vj; Tue, 02 Jun 2015 04:00:48 -0400 Received: from localhost ([127.0.0.1] helo=zen.linaro.local) by socrates.bennee.com with esmtp (Exim 4.80) (envelope-from ) id 1YziT9-0001KX-1A; Tue, 02 Jun 2015 11:26:47 +0200 References: <1432897012-1423-1-git-send-email-alex.bennee@linaro.org> <55684995.3070205@redhat.com> <877frrii83.fsf@linaro.org> <556893DB.9030502@redhat.com> <556D43C4.2070309@msgid.tls.msk.ru> From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Michael Tokarev In-reply-to: <556D43C4.2070309@msgid.tls.msk.ru> Date: Tue, 02 Jun 2015 09:01:01 +0100 Message-ID: <87vbf6bkua.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: alex.bennee@linaro.org X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 88.198.71.155 Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] configure: don't apply -O2 if extra-cflags sets -O X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 08:01:02 -0000 Michael Tokarev writes: > 29.05.2015 19:29, Paolo Bonzini wrote: >> On 29/05/2015 16:14, Alex Bennée wrote: >>> You mean just do: >>> >>> diff --git a/configure b/configure >>> index b707429..f13831a 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -353,7 +353,7 @@ for opt do >>> ;; >>> --cpu=*) cpu="$optarg" >>> ;; >>> - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS" >>> + --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg" >>> EXTRA_CFLAGS="$optarg" >>> ;; >>> --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS" >>> >>> I guess at the time I was trying to be clean and avoiding multiple -O >>> calls. But I guess that will have the same effect. >> >> Yes, that. Most other QEMU_CFLAGS assignments add at the beginning, so >> I guess the remaining ones (including the --extra-cflags one) should too. > > So, what's the final version of this patch? I can send the second patch but I'm wary about changing all instances to QEMU_CFLAGS to append additional flags. > > Thanks, > > /mjt -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzh7z-0008C4-EA for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:00:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzh7w-0008RS-7L for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:00:51 -0400 References: <1432897012-1423-1-git-send-email-alex.bennee@linaro.org> <55684995.3070205@redhat.com> <877frrii83.fsf@linaro.org> <556893DB.9030502@redhat.com> <556D43C4.2070309@msgid.tls.msk.ru> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <556D43C4.2070309@msgid.tls.msk.ru> Date: Tue, 02 Jun 2015 09:01:01 +0100 Message-ID: <87vbf6bkua.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org Michael Tokarev writes: > 29.05.2015 19:29, Paolo Bonzini wrote: >> On 29/05/2015 16:14, Alex Bennée wrote: >>> You mean just do: >>> >>> diff --git a/configure b/configure >>> index b707429..f13831a 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -353,7 +353,7 @@ for opt do >>> ;; >>> --cpu=*) cpu="$optarg" >>> ;; >>> - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS" >>> + --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg" >>> EXTRA_CFLAGS="$optarg" >>> ;; >>> --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS" >>> >>> I guess at the time I was trying to be clean and avoiding multiple -O >>> calls. But I guess that will have the same effect. >> >> Yes, that. Most other QEMU_CFLAGS assignments add at the beginning, so >> I guess the remaining ones (including the --extra-cflags one) should too. > > So, what's the final version of this patch? I can send the second patch but I'm wary about changing all instances to QEMU_CFLAGS to append additional flags. > > Thanks, > > /mjt -- Alex Bennée