From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: intel_check_page_flip() - WARN_ON(!in_interrupt()) Date: Fri, 29 May 2015 09:26:18 +0300 Message-ID: <87vbfbgar9.fsf@intel.com> References: <5567A861.8080101@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5567A861.8080101@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shuah Khan , daniel.vetter@intel.com Cc: intel-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyOSBNYXkgMjAxNSwgU2h1YWggS2hhbiA8c2h1YWhraEBvc2cuc2Ftc3VuZy5jb20+ IHdyb3RlOgo+IEkgYW0gc2VlaW5nIHRoZSBmb2xsb3dpbmcgaW4gdGhlIGRtZXNnIG9uIDQuMC40 IHdpdGggcnQgcGF0Y2gKPgo+IFsgICAgNS43MjAzMTldIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUg XS0tLS0tLS0tLS0tLQo+IFsgICAgNS43MjAzNDddIFdBUk5JTkc6IENQVTogNiBQSUQ6IDQ2NiBh dAo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYzo5NzQ4Cj4gaW50ZWxfY2hl Y2tfcGFnZV9mbGlwKzB4YWEvMHhmMCBbaTkxNV0oKQo+IFsgICAgNS43MjAzNDldIFdBUk5fT04o IWluX2ludGVycnVwdCgpKQo+IFsgICAgNS43MjAzNTBdIE1vZHVsZXMgbGlua2VkIGluOgo+IFsg ICAgNS43MjAzNzZdICBiaW5mbXRfbWlzYyByZmNvbW0gYm5lcCBhcmM0IGVlZXBjX3dtaSBoaWRf Z2VuZXJpYwo+IGFzdXNfd21pIHNwYXJzZV9rZXltYXAgaXdsbXZtIGludGVsX3Bvd2VyY2xhbXAg Y29yZXRlbXAga3ZtX2ludGVsIGt2bQo+IG1hYzgwMjExIGNyY3QxMGRpZl9wY2xtdWwgY3JjMzJf cGNsbXVsIGdoYXNoX2NsbXVsbmlfaW50ZWwgYWVzbmlfaW50ZWwKPiBhZXNfeDg2XzY0IGxydyBn ZjEyOG11bCBkbV9tdWx0aXBhdGggZ2x1ZV9oZWxwZXIgc25kX2hkYV9jb2RlY19oZG1pCj4gc2Nz aV9kaCBhYmxrX2hlbHBlciBjcnlwdGQgbWljcm9jb2RlIGJ0dXNiIGl3bHdpZmkgYmx1ZXRvb3Ro IHNlcmlvX3Jhdwo+IGNmZzgwMjExIGk5MTUgc25kX2hkYV9jb2RlY19yZWFsdGVrIHNuZF9oZGFf Y29kZWNfZ2VuZXJpYyBscGNfaWNoCj4gc25kX2hkYV9pbnRlbCBzbmRfaGRhX2NvbnRyb2xsZXIg c25kX2hkYV9jb2RlYyBzbmRfaHdkZXAgc25kX3BjbQo+IHNuZF9zZXFfbWlkaSBzbmRfc2VxX21p ZGlfZXZlbnQgc25kX3Jhd21pZGkgZHJtX2ttc19oZWxwZXIgc25kX3NlcSBkcm0KPiB2aWRlbyBz bmRfc2VxX2RldmljZSBtYWNfaGlkIHNuZF90aW1lciBzbmQgbWVpX21lIHdtaSBtZWkgc2hwY2hw Cj4gc291bmRjb3JlIGkyY19hbGdvX2JpdCB1c2JoaWQgaGlkIHBhcnBvcnRfcGMgcHBkZXYgbHAg cGFycG9ydCBhdXRvZnM0Cj4gYnRyZnMgeG9yIHJhaWQ2X3BxIHBzbW91c2UgZG1fbWlycm9yIHI4 MTY5IGFoY2kgZG1fcmVnaW9uX2hhc2ggbGliYWhjaQo+IG1paSBkbV9sb2cKPiBbICAgIDUuNzIw Mzc5XSBDUFU6IDYgUElEOiA0NjYgQ29tbTogaXJxLzMyLWk5MTUgTm90IHRhaW50ZWQgNC4wLjQt cnQxKyAjOAo+IFsgICAgNS43MjAzODBdIEhhcmR3YXJlIG5hbWU6IFN5c3RlbTc2LCBJbmMuIFdp bGQgRG9nCj4gUGVyZm9ybWFuY2UvSDg3LVBMVVMsIEJJT1MgMDcwNSAxMi8wNS8yMDEzCj4gWyAg ICA1LjcyMDM4Ml0gIDAwMDAwMDAwMDAwMDAwMDkgZmZmZjg4MDNlYTM5YmM5OCBmZmZmZmZmZjgx N2MwNjk0Cj4gMDAwMDAwMDAwMDAwMDAwMgo+IFsgICAgNS43MjAzODNdICBmZmZmODgwM2VhMzli Y2U4IGZmZmY4ODAzZWEzOWJjZDggZmZmZmZmZmY4MTA3M2Q4YQo+IDAwMDAwMDAwMDAwMDAwMDEK PiBbICAgIDUuNzIwMzg0XSAgZmZmZjg4MDNlYjE4NDAwMCBmZmZmODgwMGQ3ODA0ODAwIDAwMDAw MDAwMDAwMDAwMDAKPiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAgICA1LjcyMDM4NV0gQ2FsbCBUcmFj ZToKPiBbICAgIDUuNzIwMzkwXSAgWzxmZmZmZmZmZjgxN2MwNjk0Pl0gZHVtcF9zdGFjaysweDRm LzB4OTAKPiBbICAgIDUuNzIwMzkzXSAgWzxmZmZmZmZmZjgxMDczZDhhPl0gd2Fybl9zbG93cGF0 aF9jb21tb24rMHg4YS8weGUwCj4gWyAgICA1LjcyMDM5NV0gIFs8ZmZmZmZmZmY4MTA3M2UyNj5d IHdhcm5fc2xvd3BhdGhfZm10KzB4NDYvMHg1MAo+IFsgICAgNS43MjA0MTBdICBbPGZmZmZmZmZm YTA0MGJkYmE+XSBpbnRlbF9jaGVja19wYWdlX2ZsaXArMHhhYS8weGYwIFtpOTE1XQo+IFsgICAg NS43MjA0MjBdICBbPGZmZmZmZmZmYTAzZDc4ODg+XSBpcm9ubGFrZV9pcnFfaGFuZGxlcisweDJl OC8weDEwMDAKPiBbaTkxNV0KPiBbICAgIDUuNzIwNDIzXSAgWzxmZmZmZmZmZjgxM2U3Nzg3Pl0g PyBkZWJ1Z19zbXBfcHJvY2Vzc29yX2lkKzB4MTcvMHgyMAo+IFsgICAgNS43MjA0MjRdICBbPGZm ZmZmZmZmODEwNzQ1MTI+XSA/IHBpbl9jdXJyZW50X2NwdSsweDkyLzB4MWQwCj4gWyAgICA1Ljcy MDQyNl0gIFs8ZmZmZmZmZmY4MTBkMDY5MD5dID8gaXJxX3RocmVhZF9mbisweDUwLzB4NTAKPiBb ICAgIDUuNzIwNDI4XSAgWzxmZmZmZmZmZjgxMGQwNmI3Pl0gaXJxX2ZvcmNlZF90aHJlYWRfZm4r MHgyNy8weDgwCj4gWyAgICA1LjcyMDQyOV0gIFs8ZmZmZmZmZmY4MTBkMGM0Zj5dIGlycV90aHJl YWQrMHgxMGYvMHgxNjAKPiBbICAgIDUuNzIwNDMwXSAgWzxmZmZmZmZmZjgxMGQwNzQwPl0gPyB3 YWtlX3RocmVhZHNfd2FpdHErMHgzMC8weDMwCj4gWyAgICA1LjcyMDQzMl0gIFs8ZmZmZmZmZmY4 MTBkMGI0MD5dID8gaXJxX3RocmVhZF9jaGVja19hZmZpbml0eSsweDkwLzB4OTAKPiBbICAgIDUu NzIwNDMzXSAgWzxmZmZmZmZmZjgxMDkzZDdiPl0ga3RocmVhZCsweGJiLzB4ZTAKPiBbICAgIDUu NzIwNDM0XSAgWzxmZmZmZmZmZjgxMDkzY2MwPl0gPyBrdGhyZWFkX3dvcmtlcl9mbisweDFhMC8w eDFhMAo+IFsgICAgNS43MjA0MzZdICBbPGZmZmZmZmZmODE3YzZiZDg+XSByZXRfZnJvbV9mb3Jr KzB4NTgvMHg5MAo+IFsgICAgNS43MjA0MzddICBbPGZmZmZmZmZmODEwOTNjYzA+XSA/IGt0aHJl YWRfd29ya2VyX2ZuKzB4MWEwLzB4MWEwCj4gWyAgICA1LjcyMDQzN10gLS0tWyBlbmQgdHJhY2Ug MDAwMDAwMDAwMDAwMDAwMiBdLS0tCj4KPiBUaGVyZSBzZWVtIHRvIGJlIGZldyBwYXN0IGJ1ZyBy ZXBvcnRzIG9uIHRoaXMgaXNzdWUuIEhhcyB0aGlzIGJlZW4KPiBmaXhlZD8gU2hvdWxkIEkgYmUg Y29uY2VybmVkIGFib3V0IHRoaXM/CgpPbmUgb2YgdGhlIG9sZCBidWdzIFsxXSB3YXMgYWJvdXQg dXNpbmcgaW5faXJxKCkgd2hpY2ggZGlkbid0IHdvcmsgZm9yCnRocmVhZGVkIGlycXMsIGhlbmNl IHRoZSBzd2l0Y2ggdG8gaW5faW50ZXJydXB0KCkuIFRoZSBiYWNrdHJhY2Ugc2VlbXMKdG8gaW5k aWNhdGUgaW50ZWxfY2hlY2tfcGFnZV9mbGlwKCkgaXMgYmVpbmcgY2FsbGVkIGZyb20gaXJxIGNv bnRleHQ7IEkKZG8gbm90IGtub3cgaWYgdGhlIHJ0IHBhdGNoc2V0IGhhcyBhbiBpbXBhY3Qgb24g dGhpcy4KCkJSLApKYW5pLgoKClsxXSBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3df YnVnLmNnaT9pZD04OTMyMQoKPgo+IHRoYW5rcywKPiAtLSBTaHVhaAo+Cj4gLS0gCj4gU2h1YWgg S2hhbgo+IFNyLiBMaW51eCBLZXJuZWwgRGV2ZWxvcGVyCj4gT3BlbiBTb3VyY2UgSW5ub3ZhdGlv biBHcm91cAo+IFNhbXN1bmcgUmVzZWFyY2ggQW1lcmljYSAoU2lsaWNvbiBWYWxsZXkpCj4gc2h1 YWhraEBvc2cuc2Ftc3VuZy5jb20gfCAoOTcwKSAyMTctODk3OAoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755453AbbE2GYQ (ORCPT ); Fri, 29 May 2015 02:24:16 -0400 Received: from mga02.intel.com ([134.134.136.20]:40356 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755397AbbE2GYK (ORCPT ); Fri, 29 May 2015 02:24:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,514,1427785200"; d="scan'208";a="733540646" From: Jani Nikula To: Shuah Khan , daniel.vetter@intel.com Cc: "linux-kernel\@vger.kernel.org" , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: intel_check_page_flip() - WARN_ON(!in_interrupt()) In-Reply-To: <5567A861.8080101@osg.samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <5567A861.8080101@osg.samsung.com> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 29 May 2015 09:26:18 +0300 Message-ID: <87vbfbgar9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015, Shuah Khan wrote: > I am seeing the following in the dmesg on 4.0.4 with rt patch > > [ 5.720319] ------------[ cut here ]------------ > [ 5.720347] WARNING: CPU: 6 PID: 466 at > drivers/gpu/drm/i915/intel_display.c:9748 > intel_check_page_flip+0xaa/0xf0 [i915]() > [ 5.720349] WARN_ON(!in_interrupt()) > [ 5.720350] Modules linked in: > [ 5.720376] binfmt_misc rfcomm bnep arc4 eeepc_wmi hid_generic > asus_wmi sparse_keymap iwlmvm intel_powerclamp coretemp kvm_intel kvm > mac80211 crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel > aes_x86_64 lrw gf128mul dm_multipath glue_helper snd_hda_codec_hdmi > scsi_dh ablk_helper cryptd microcode btusb iwlwifi bluetooth serio_raw > cfg80211 i915 snd_hda_codec_realtek snd_hda_codec_generic lpc_ich > snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm > snd_seq_midi snd_seq_midi_event snd_rawmidi drm_kms_helper snd_seq drm > video snd_seq_device mac_hid snd_timer snd mei_me wmi mei shpchp > soundcore i2c_algo_bit usbhid hid parport_pc ppdev lp parport autofs4 > btrfs xor raid6_pq psmouse dm_mirror r8169 ahci dm_region_hash libahci > mii dm_log > [ 5.720379] CPU: 6 PID: 466 Comm: irq/32-i915 Not tainted 4.0.4-rt1+ #8 > [ 5.720380] Hardware name: System76, Inc. Wild Dog > Performance/H87-PLUS, BIOS 0705 12/05/2013 > [ 5.720382] 0000000000000009 ffff8803ea39bc98 ffffffff817c0694 > 0000000000000002 > [ 5.720383] ffff8803ea39bce8 ffff8803ea39bcd8 ffffffff81073d8a > 0000000000000001 > [ 5.720384] ffff8803eb184000 ffff8800d7804800 0000000000000000 > 0000000000000000 > [ 5.720385] Call Trace: > [ 5.720390] [] dump_stack+0x4f/0x90 > [ 5.720393] [] warn_slowpath_common+0x8a/0xe0 > [ 5.720395] [] warn_slowpath_fmt+0x46/0x50 > [ 5.720410] [] intel_check_page_flip+0xaa/0xf0 [i915] > [ 5.720420] [] ironlake_irq_handler+0x2e8/0x1000 > [i915] > [ 5.720423] [] ? debug_smp_processor_id+0x17/0x20 > [ 5.720424] [] ? pin_current_cpu+0x92/0x1d0 > [ 5.720426] [] ? irq_thread_fn+0x50/0x50 > [ 5.720428] [] irq_forced_thread_fn+0x27/0x80 > [ 5.720429] [] irq_thread+0x10f/0x160 > [ 5.720430] [] ? wake_threads_waitq+0x30/0x30 > [ 5.720432] [] ? irq_thread_check_affinity+0x90/0x90 > [ 5.720433] [] kthread+0xbb/0xe0 > [ 5.720434] [] ? kthread_worker_fn+0x1a0/0x1a0 > [ 5.720436] [] ret_from_fork+0x58/0x90 > [ 5.720437] [] ? kthread_worker_fn+0x1a0/0x1a0 > [ 5.720437] ---[ end trace 0000000000000002 ]--- > > There seem to be few past bug reports on this issue. Has this been > fixed? Should I be concerned about this? One of the old bugs [1] was about using in_irq() which didn't work for threaded irqs, hence the switch to in_interrupt(). The backtrace seems to indicate intel_check_page_flip() is being called from irq context; I do not know if the rt patchset has an impact on this. BR, Jani. [1] https://bugs.freedesktop.org/show_bug.cgi?id=89321 > > thanks, > -- Shuah > > -- > Shuah Khan > Sr. Linux Kernel Developer > Open Source Innovation Group > Samsung Research America (Silicon Valley) > shuahkh@osg.samsung.com | (970) 217-8978 -- Jani Nikula, Intel Open Source Technology Center