From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbTiL-0008LQ-Qj for qemu-devel@nongnu.org; Fri, 27 Mar 2015 08:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbTiG-0001kz-NG for qemu-devel@nongnu.org; Fri, 27 Mar 2015 08:50:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbTiG-0001kt-8C for qemu-devel@nongnu.org; Fri, 27 Mar 2015 08:50:12 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> Date: Fri, 27 Mar 2015 13:50:07 +0100 In-Reply-To: <1427227433-5030-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 24 Mar 2015 14:03:25 -0600") Message-ID: <87vbhmk3k0.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com Eric Blake writes: > After several months of sitting on this, I finally made progress > on it. Let's get it in 2.4, and I promise to kick out a v6 > (if needed) with much less delay. > > We want to eventually allow qapi defaults, by making: > 'data':{'*flag':'bool'} > shorthand for: > 'data':{'flag':{'type':'bool', 'optional':true}} > so that the default can be specified: > 'data':{'flag':{'type':'bool', 'optional':true, 'default':true}} > > This series does not quite get us there, but it DOES do a number > of other things. It gets rid of the three uses of nested inline > structs, changes anonymous unions to use a specific 'alternate' > metatype rather than abusing 'union', and fixes lots of other > parser bugs found while designing the testsuite. The testsuite > changes make the bulk of this series, with a repeating pattern > of writing tests that expose weaknesses in the old parser, then > beefing up the generator to catch the problem during the initial > parse rather than choking with an obscure python message or even > causing a C compilation failure. > > v4 was here: > https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg04022.html > > Changes since then: lots of refactoring; 8 new commits; lots of > testsuite additions; address Markus' review comments where I > could. However, so much has changed, and so much time elapsed, > that it is probably easier to just review this series fresh than > to try and compare it to earlier versions. Okay, I'm through. I like it well, and I think it's really close. There are a few questions / ideas you haven't replied to already in PATCH 21ff. With those conversations wrapped up, I may well agree to taking the series as is, but I think I'd prefer a *conservative* respin addressing stuff that doesn't need new testing, like commit messages and comments, and *selected* (by you) improvments that do need new testing.