From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists Date: Wed, 04 Mar 2015 16:27:29 +0000 Message-ID: <87vbig683y.fsf@linaro.org> References: <1425479753-18349-1-git-send-email-alex.bennee@linaro.org> <1425479753-18349-7-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Sender: kvm-owner@vger.kernel.org To: Peter Maydell Cc: QEMU Developers , kvm-devel , arm-mail-list , "kvmarm@lists.cs.columbia.edu" , Christoffer Dall , Marc Zyngier List-Id: kvmarm@lists.cs.columbia.edu Peter Maydell writes: > On 4 March 2015 at 23:35, Alex Benn=C3=A9e w= rote: >> I was getting very confused about the duplication of state. Perhaps = we >> should just get rid of env->spsr and use helpers that understand the >> banking? > > Doesn't seem worth changing the current working code to something > else that's strictly less efficient... spsr is by no means the > only banked-by-mode register, and it works just like all the others. =46air enough. I just wanted to make it clear it was a cached value for the benefit of TCG. > > -- PMM --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Wed, 04 Mar 2015 16:27:29 +0000 Subject: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists In-Reply-To: References: <1425479753-18349-1-git-send-email-alex.bennee@linaro.org> <1425479753-18349-7-git-send-email-alex.bennee@linaro.org> Message-ID: <87vbig683y.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Peter Maydell writes: > On 4 March 2015 at 23:35, Alex Benn?e wrote: >> I was getting very confused about the duplication of state. Perhaps we >> should just get rid of env->spsr and use helpers that understand the >> banking? > > Doesn't seem worth changing the current working code to something > else that's strictly less efficient... spsr is by no means the > only banked-by-mode register, and it works just like all the others. Fair enough. I just wanted to make it clear it was a cached value for the benefit of TCG. > > -- PMM -- Alex Benn?e From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists Date: Wed, 04 Mar 2015 16:27:29 +0000 Message-ID: <87vbig683y.fsf@linaro.org> References: <1425479753-18349-1-git-send-email-alex.bennee@linaro.org> <1425479753-18349-7-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: QEMU Developers , kvm-devel , arm-mail-list , "kvmarm\@lists.cs.columbia.edu" , Christoffer Dall , Marc Zyngier To: Peter Maydell Return-path: Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:52630 "EHLO socrates.bennee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932766AbbCDQ1e (ORCPT ); Wed, 4 Mar 2015 11:27:34 -0500 In-reply-to: Sender: kvm-owner@vger.kernel.org List-ID: Peter Maydell writes: > On 4 March 2015 at 23:35, Alex Benn=C3=A9e w= rote: >> I was getting very confused about the duplication of state. Perhaps = we >> should just get rid of env->spsr and use helpers that understand the >> banking? > > Doesn't seem worth changing the current working code to something > else that's strictly less efficient... spsr is by no means the > only banked-by-mode register, and it works just like all the others. =46air enough. I just wanted to make it clear it was a cached value for the benefit of TCG. > > -- PMM --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTC95-00006J-27 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 11:27:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTC91-0007vq-Rc for qemu-devel@nongnu.org; Wed, 04 Mar 2015 11:27:39 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:58568 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTC91-0007ve-LV for qemu-devel@nongnu.org; Wed, 04 Mar 2015 11:27:35 -0500 References: <1425479753-18349-1-git-send-email-alex.bennee@linaro.org> <1425479753-18349-7-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Wed, 04 Mar 2015 16:27:29 +0000 Message-ID: <87vbig683y.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kvm-devel , Marc Zyngier , QEMU Developers , Christoffer Dall , "kvmarm@lists.cs.columbia.edu" , arm-mail-list Peter Maydell writes: > On 4 March 2015 at 23:35, Alex Bennée wrote: >> I was getting very confused about the duplication of state. Perhaps we >> should just get rid of env->spsr and use helpers that understand the >> banking? > > Doesn't seem worth changing the current working code to something > else that's strictly less efficient... spsr is by no means the > only banked-by-mode register, and it works just like all the others. Fair enough. I just wanted to make it clear it was a cached value for the benefit of TCG. > > -- PMM -- Alex Bennée