From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: Intentionally corrupted vfat fs causing BUG Date: Fri, 24 Oct 2014 02:35:18 +0900 Message-ID: <87vbna7kq1.fsf@devron.myhome.or.jp> References: <8761fo7667.fsf@devron.myhome.or.jp> <543B8BC7.1040501@nod.at> <87y4sk5pul.fsf@devron.myhome.or.jp> <543B8FA7.9000106@nod.at> <87r3yc5oqt.fsf@devron.myhome.or.jp> <5443E87A.2060207@nod.at> <87oat29551.fsf@devron.myhome.or.jp> <20141023160106.GB7996@ZenIV.linux.org.uk> <20141023161606.GC7996@ZenIV.linux.org.uk> <877fzq91ky.fsf@devron.myhome.or.jp> <20141023165533.GD7996@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Cc: Richard Weinberger , Sami Liedes , linux-fsdevel To: Al Viro Return-path: Received: from mail.parknet.co.jp ([210.171.160.6]:45007 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbaJWRfW (ORCPT ); Thu, 23 Oct 2014 13:35:22 -0400 In-Reply-To: <20141023165533.GD7996@ZenIV.linux.org.uk> (Al Viro's message of "Thu, 23 Oct 2014 17:55:33 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro writes: > On Fri, Oct 24, 2014 at 01:45:49AM +0900, OGAWA Hirofumi wrote: > >> d_splice_alias() calls __d_find_alias() with want_discon==1, so >> __d_find_alias() doesn't return dentry, and d_splice_alias() doesn't use >> d_move() path, right? > > Hmm... Not in the current mainline (and not because of want_discon - that's > gone already). However, with the fixes I've got in the local tree it > will both find and move it - same as d_materialise_unique() would in the > current mainline. Ah, I see. Checked latest linus tree, looks like added some checks (I was still working on 3.6.15, sorry). So, Richard, can you add comment such as /* Check FS corruption, will handle by d_splice_alias() */ for that less understandable check, and resend patch with your Signed-off-by: (better to Cc: akpm)? Acked-by: OGAWA Hirofumi Thanks. -- OGAWA Hirofumi