From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS9N2-0000oM-Cd for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS9Mw-0002U5-7Q for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:45:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS9Mv-0002Tq-Vw for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:45:22 -0400 From: Markus Armbruster References: <1410336832-22160-1-git-send-email-armbru@redhat.com> <1410336832-22160-9-git-send-email-armbru@redhat.com> <541077A0.1050003@redhat.com> Date: Thu, 11 Sep 2014 20:45:17 +0200 In-Reply-To: <541077A0.1050003@redhat.com> (Eric Blake's message of "Wed, 10 Sep 2014 10:09:04 -0600") Message-ID: <87vbou808y.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, benoit.canet@irqsave.net, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Eric Blake writes: > On 09/10/2014 02:13 AM, Markus Armbruster wrote: >> device_name[] is can become non-empty only in bdrv_new_named() and > > s/is // Fixing, thanks! >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by blk_new_with_bs(). >> Therefore, when a BlockDriverState's device_name[] is non-empty, then >> it's owned by a BlockBackend. >> >> The converse is also true, because blk_attach_bs() is called only by >> blk_new_with_bs() so far. >> >> Furthermore, blk_new_with_bs() keeps the two names equal. >> >> Therefore, device_name[] is redundant. Eliminate it. >> >> Signed-off-by: Markus Armbruster >> ---