All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC/PATCH 1/2] perf top: Fix -z option behavior
Date: Wed, 13 Aug 2014 13:52:51 +0900	[thread overview]
Message-ID: <87vbpxdm8s.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <53EA6495.4010600@gmail.com> (David Ahern's message of "Tue, 12 Aug 2014 13:01:41 -0600")

Hi David,

On Tue, 12 Aug 2014 13:01:41 -0600, David Ahern wrote:
> On 8/12/14, 2:16 AM, Namhyung Kim wrote:
>> The current -z option does almost nothing.  It doesn't zero the
>> existing samples so that we can see profiles of exited process after
>> last refresh.  It seems it only affects annotation.
>>
>> This patch clears existing entries before processing if -z option is
>> given.  For this original decaying logic also moved before processing.
>
> This option was broken somewhere recently. I am on vacation for
> another week, so I can't do a git bisect myself but I recall it worked
> a year or so ago. Try v3.4 as a start point.

Are you sure?  I don't recall seeing any big change in this area so I
guess the problem existed since long time ago.  In fact I couldn't find
a logic to zero/clear out existing hist entries in a hists..

Thanks,
Namhyung

  reply	other threads:[~2014-08-13  4:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12  8:16 [RFC/PATCH 1/2] perf top: Fix -z option behavior Namhyung Kim
2014-08-12  8:16 ` [PATCH 2/2] perf top: Handle 'z' key for toggle zeroing samples in TUI Namhyung Kim
2014-08-12 23:07   ` Stephane Eranian
2014-08-13 20:37     ` Arnaldo Carvalho de Melo
2014-08-13 20:47       ` Stephane Eranian
2014-08-19  6:09         ` Namhyung Kim
2014-08-14  8:49   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 19:01 ` [RFC/PATCH 1/2] perf top: Fix -z option behavior David Ahern
2014-08-13  4:52   ` Namhyung Kim [this message]
2014-08-13  5:47     ` David Ahern
2014-08-13 20:20       ` Arnaldo Carvalho de Melo
2014-08-12 23:05 ` Stephane Eranian
2014-08-13 20:27 ` Arnaldo Carvalho de Melo
2014-08-19  6:07   ` Namhyung Kim
2014-08-14  8:49 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbpxdm8s.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.