All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] perf script: Fix possible memory leaks
Date: Mon, 11 Aug 2014 16:45:41 +0900	[thread overview]
Message-ID: <87vbpzfp0a.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <53DB7AC3.3030207@intel.com> (Adrian Hunter's message of "Fri, 01 Aug 2014 14:32:19 +0300")

Hi Adrian,

On Fri, 01 Aug 2014 14:32:19 +0300, Adrian Hunter wrote:
> On 1/08/2014 11:24 a.m., Namhyung Kim wrote:
>> Some paths in perf script don't call perf_session__delete() after
>> creating a new session.
>>

[SNIP]
>> -	perf_session__delete(session);
>>   	cleanup_scripting();
>> +out_delete:
>> +	perf_session__delete(session);
>
> Some of the db-export scripting I do relies on the session
> being deleted before the script is stopped.  I would prefer
> the original order i.e. perf_session__delete() then
> cleanup_scripting()

Okay, I'll fix it and send v2.

Thanks,
Namhyung

      reply	other threads:[~2014-08-11  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01  8:24 [PATCH] perf script: Fix possible memory leaks Namhyung Kim
2014-08-01 11:32 ` Adrian Hunter
2014-08-11  7:45   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbpzfp0a.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.