From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Dave Taht <dave.taht@gmail.com>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Reporting firmware stats to ethtool
Date: Sat, 9 Aug 2014 09:30:06 +0300 [thread overview]
Message-ID: <87vbq2uqdt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <53E4FEA9.80803@broadcom.com> (Arend van Spriel's message of "Fri, 8 Aug 2014 18:45:29 +0200")
Arend van Spriel <arend@broadcom.com> writes:
>>> I do kind of prefer 64 bit counters in the general case. Nuke it from
>>> orbit, it's the only way to be sure.
>>
>> It's 64-bit to user-space, but that means nothing because firmware
>> uses 32-bit (or even 16 bit in some cases, probably) internally.
>> A great deal of counters are the same, so be very careful when
>> trying to keep long term counters grabbed from firmware/drivers/hardware.
>>
>> And, stations come and go when you re-associate, so all sorts of wifi counters
>> reset themselves all the time...
>
> Does ath driver notify mac80211 about firmware restart, ie. through
> ieee80211_restart_hw().
ath10k does use ieee80211_restart_hw().
> If only user-space could get that info.
Yeah, that would be nice to have for ath10k firmware crash dump
functionality. And doesn't Android also need something similar?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Ben Greear <greearb@candelatech.com>,
Dave Taht <dave.taht@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Reporting firmware stats to ethtool
Date: Sat, 9 Aug 2014 09:30:06 +0300 [thread overview]
Message-ID: <87vbq2uqdt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <53E4FEA9.80803@broadcom.com> (Arend van Spriel's message of "Fri, 8 Aug 2014 18:45:29 +0200")
Arend van Spriel <arend@broadcom.com> writes:
>>> I do kind of prefer 64 bit counters in the general case. Nuke it from
>>> orbit, it's the only way to be sure.
>>
>> It's 64-bit to user-space, but that means nothing because firmware
>> uses 32-bit (or even 16 bit in some cases, probably) internally.
>> A great deal of counters are the same, so be very careful when
>> trying to keep long term counters grabbed from firmware/drivers/hardware.
>>
>> And, stations come and go when you re-associate, so all sorts of wifi counters
>> reset themselves all the time...
>
> Does ath driver notify mac80211 about firmware restart, ie. through
> ieee80211_restart_hw().
ath10k does use ieee80211_restart_hw().
> If only user-space could get that info.
Yeah, that would be nice to have for ath10k firmware crash dump
functionality. And doesn't Android also need something similar?
--
Kalle Valo
next prev parent reply other threads:[~2014-08-09 6:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 21:57 Reporting firmware stats to ethtool Ben Greear
2014-08-07 21:57 ` Ben Greear
2014-08-08 9:06 ` Kalle Valo
2014-08-08 9:06 ` Kalle Valo
2014-08-08 15:42 ` Ben Greear
2014-08-08 15:42 ` Ben Greear
2014-08-08 15:55 ` Dave Taht
2014-08-08 15:55 ` Dave Taht
2014-08-08 16:11 ` Ben Greear
2014-08-08 16:11 ` Ben Greear
2014-08-08 16:45 ` Arend van Spriel
2014-08-08 16:45 ` Arend van Spriel
2014-08-08 17:24 ` Ben Greear
2014-08-08 17:24 ` Ben Greear
2014-08-09 6:32 ` Kalle Valo
2014-08-09 6:32 ` Kalle Valo
2014-08-09 6:30 ` Kalle Valo [this message]
2014-08-09 6:30 ` Kalle Valo
2014-08-09 7:30 ` Arend van Spriel
2014-08-09 7:30 ` Arend van Spriel
2014-08-09 15:56 ` Kalle Valo
2014-08-09 15:56 ` Kalle Valo
2014-08-09 6:27 ` Kalle Valo
2014-08-09 6:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbq2uqdt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=arend@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=dave.taht@gmail.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.