From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X6fGr-0001Pj-W8
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 08:22:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X6fGm-0006KB-0g
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 08:22:17 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:39837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X6fGl-0006JK-R0
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 08:22:11 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <8738e4fb5y.fsf@blackfin.pond.sub.org>
	<CAEgOgz5XE_0udwDYEB6i5MHBAVy8x7g_TmdN3m6uABbdQSKWBA@mail.gmail.com>
Date: Mon, 14 Jul 2014 14:22:08 +0200
In-Reply-To: <CAEgOgz5XE_0udwDYEB6i5MHBAVy8x7g_TmdN3m6uABbdQSKWBA@mail.gmail.com>
	(Peter Crosthwaite's message of "Mon, 14 Jul 2014 21:48:12 +1000")
Message-ID: <87vbr09llb.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] Hot unplug of pci-serial-2x fails assertion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:

> On Mon, Jul 14, 2014 at 9:10 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> Watch this:
>>
>>     (qemu) chardev-add file,path=foo2,id=foo2
>>     (qemu) chardev-add file,path=foo3,id=foo3
>>     (qemu) device_add id=gg,driver=pci-serial-2x,chardev1=foo2,chardev2=foo3
>>     (qemu) device_del gg
>>     (qemu) upstream-qemu: /work/armbru/qemu/memory.c:1259:
>> memory_region_finalize: Assertion `((&mr->subregions)->tqh_first ==
>> ((void *)0))' failed.
>>
>
> Are there more specifics to reproduction? I'm struggling and I've
> tried a few variants.
>
> Curiously I can device_del gg repeatedly with seemingly no effect however:
>
> pcrost@pcrost-K42F:~/qemu$ ./x86_64-softmmu/qemu-system-x86_64  -nographic
> QEMU 2.0.91 monitor - type 'help' for more information
> (qemu)  chardev-add file,path=foo2,id=foo2
> (qemu)  chardev-add file,path=foo3,id=foo3
> (qemu) device_add id=gg,driver=pci-serial-2x,chardev1=foo2,chardev2=foo3
> (qemu) device_del gg
> (qemu) device_del gg
> (qemu) device_del gg
> (qemu) info qtree
> bus: main-system-bus
>   type System
>   dev: hpet, id ""
>     gpio-in "" 2
>     gpio-out "" 1
>     timers = 3 (0x3)
>     msi = false
>     hpet-intcap = 4 (0x4)
>     irq 32
>     mmio 00000000fed00000/0000000000000400
>   dev: ioapic, id ""
>     gpio-in "" 24
>     irq 0
>     mmio 00000000fec00000/0000000000001000
>   dev: i440FX-pcihost, id ""
>     pci-hole64-size = 18446744073709551615 (16 EiB)
>     short_root_bus = 0 (0x0)
>     irq 0
>     bus: pci.0
>       type PCI
>       dev: pci-serial-2x, id "gg"
>         chardev1 = "foo2"
>         chardev2 = "foo3"
>         prog_if = 2 (0x2)
>         addr = 04.0
>         romfile = ""
>         rombar = 1 (0x1)
>         multifunction = false
>         command_serr_enable = true
>         class Serial port, addr 00:04.0, pci id 1b36:0003 (sub 1af4:1100)
>         bar 0: i/o at 0xffffffffffffffff [0xe]
>
> Am I missing something?

Is your guest running and honoring ACPI unplug requests?

See also Paolo's reply, which points to a patch.