All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
To: Peter Stuge <peter-Y+HMSxxDrH8@public.gmane.org>,
	Enrico Mioso <mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org,
	David.Laight-JxhZ9S5GRejQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool
Date: Sun, 18 May 2014 16:50:30 +0200	[thread overview]
Message-ID: <87vbt3m98p.fsf@nemi.mork.no> (raw)
In-Reply-To: <alpine.LNX.2.03.1405181155310.7743-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Enrico Mioso's message of "Sun, 18 May 2014 11:57:05 +0200 (CEST)")

I could be wrong, but my impression is that the userspace API
preferences for network devices are

 1. ethtool
 2. sysfs
 3. module param
 ..
 99. ioctl

This is the primary reason why I was looking for someplace to put this
within the existing ethtool API.  Using sysfs would have worked fine
too, I guess.  But is there any real advantage, making it worth a
switch?  I am all open to change to sysfs instead before v3.16 is
released, *if* there are good reasons to do it. And no objections.  But
I do want more of a reason than the fact that it can be done.  Maybe I
got the preferred order wrong?

I ruled out module parameters early because I believe there are real use
cases requiring different settings per device.  The limited host system
resources will of course affect all devices on a single host the same
way.  But not all devices can cope with the reduced buffers. So there
should be some way to tune two devices connected to the same host
differently.

I am not going to say anything about ioctls :-)


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-05-18 14:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 19:48 [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 01/12] net: cdc_ncm: split out rx_max/tx_max update of setup Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 02/12] net: cdc_ncm: factor out one-time device initialization Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 03/12] net: cdc_ncm: split .bind " Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 04/12] net: cdc_ncm: support rx_max/tx_max updates when running Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 05/12] net: cdc_ncm: use ethtool to tune coalescing settings Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 06/12] net: cdc_ncm: use true max dgram count for header estimates Bjørn Mork
     [not found] ` <1400269709-18854-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2014-05-16 19:48   ` [PATCH net-next v2 07/12] net: cdc_ncm: set reasonable padding limits Bjørn Mork
2014-05-16 19:48   ` [PATCH net-next v2 08/12] net: cdc_ncm/cdc_mbim: adding NCM protocol statistics Bjørn Mork
2014-05-16 19:48   ` [PATCH net-next v2 09/12] net: cdc_ncm: use sane defaults for rx/tx buffers Bjørn Mork
2014-05-17  2:40   ` [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool David Miller
     [not found]     ` <20140516.224032.2301577488192248796.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-05-17  6:46       ` Bjørn Mork
     [not found]         ` <87d2fcoqay.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-05-18  1:19           ` Peter Stuge
2014-05-18  9:57             ` Enrico Mioso
     [not found]               ` <alpine.LNX.2.03.1405181155310.7743-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-18 14:50                 ` Bjørn Mork [this message]
2014-05-18 17:10                   ` Lars Melin
2014-05-19  7:36                     ` Bjørn Mork
2014-05-20  7:36                       ` Bjørn Mork
     [not found]                       ` <87egzqmd8h.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-06-08 22:02                         ` Ben Hutchings
2014-05-18 22:08                   ` David Miller
2014-05-16 19:48 ` [PATCH net-next v2 10/12] net: cdc_ncm: fix argument alignment Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 11/12] net: cdc_ncm: remove redundant "disconnected" flag Bjørn Mork
2014-05-16 19:48 ` [PATCH net-next v2 12/12] net: cdc_ncm: do not start timer on an empty skb Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbt3m98p.fsf@nemi.mork.no \
    --to=bjorn-yokvzcmfvru@public.gmane.org \
    --cc=David.Laight-JxhZ9S5GRejQT0dZR+AlfA@public.gmane.org \
    --cc=alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
    --cc=peter-Y+HMSxxDrH8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.