From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send
Date: Tue, 21 Jan 2014 14:12:48 +0200 [thread overview]
Message-ID: <87vbxd5y9r.fsf@intel.com> (raw)
In-Reply-To: <20140121115927.GE8968@strange.amr.corp.intel.com>
On Tue, 21 Jan 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Tue, Jan 21, 2014 at 12:07:23PM +0200, Jani Nikula wrote:
>> Some general bikeshedding...
>>
>> I really wish everyone would write commit messages that work independent
>> of the patch subject. Just like a newspaper article should make sense
>> and tell a story also in the absence of a headline.
>
> Will keep this in mind next time (one could argue we're in deep
> bikeshedding water here!).
Well, yeah. Nothing personal, Damien, times_this_has_annoyed_me++ just
grew beyond some threshold at this patch. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-21 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 15:52 New DP vfuncs get_aux{clock_divider,send_ctl} Damien Lespiau
2014-01-20 15:52 ` [PATCH 1/4] drm/i915: Turn get_aux_clock_divider() into per-product vfuncs Damien Lespiau
2014-01-21 9:49 ` Jani Nikula
2014-01-21 13:35 ` [PATCH 1/4 v2] drm/i915: Turn get_aux_clock_divider() into per-platform vfuncs Damien Lespiau
2014-01-21 15:52 ` Jani Nikula
2014-01-20 15:52 ` [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send Damien Lespiau
2014-01-21 10:07 ` Jani Nikula
2014-01-21 11:59 ` Damien Lespiau
2014-01-21 12:12 ` Jani Nikula [this message]
2014-01-20 15:52 ` [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order Damien Lespiau
2014-01-21 10:09 ` Jani Nikula
2014-01-21 11:17 ` Damien Lespiau
2014-01-20 15:52 ` [PATCH 4/4] drm/i915: Introduce a get_aux_send_ctl() vfunc Damien Lespiau
2014-01-21 10:12 ` Jani Nikula
2014-01-21 13:37 ` [PATCH 4/4 v2] " Damien Lespiau
2014-01-21 16:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbxd5y9r.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.