From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VqNwK-0006kj-5d
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:05:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VqNwE-0005W6-VU
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:05:32 -0500
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:35764 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VqNwE-0005W1-Pu
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:05:26 -0500
References: <1386612744-1013-1-git-send-email-peter.maydell@linaro.org>
	<1386612744-1013-2-git-send-email-peter.maydell@linaro.org>
	<52A62562.7040005@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <52A62562.7040005@twiddle.net>
Date: Tue, 10 Dec 2013 14:05:25 +0000
Message-ID: <87vbyw6btm.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/9] target-arm: A64: add support for stp
	(store pair)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, patches@linaro.org, Michael Matz <matz@suse.de>, qemu-devel@nongnu.org, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>


rth@twiddle.net writes:

> On 12/09/2013 10:12 AM, Peter Maydell wrote:
<snip>
>> +    if (wback) {
>> +        if (postindex) {
>> +            tcg_gen_addi_i64(tcg_addr, tcg_addr, offset - (1 << size));
>> +        } else {
>> +            tcg_gen_subi_i64(tcg_addr, tcg_addr, 1 << size);
>> +        }
>
> Perhaps better as
>
>     tcg_gen_addi_i64(tcg_addr, tcg_addr,
>                      (postindex ? offset : 0) - (1 << size));

I'm not so sure it's easier to follow despite my general proclivity for
ternary operator.

>
>
> ?
>
>
> r~

-- 
Alex Bennée
QEMU/KVM Hacker for Linaro