From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hitoshi Mitake <mitake.hitoshi@gmail.com>
Subject: Re: [PATCH] Add an array that describes which opcodes are supported by the RDWR and SHEEPDOG backends.
Date: Thu, 17 Oct 2013 22:47:00 +0900
Message-ID: <87vc0wqaaz.wl%mitake.hitoshi@gmail.com>
References: <1381588740-25968-1-git-send-email-ronniesahlberg@gmail.com>
	<1381588740-25968-2-git-send-email-ronniesahlberg@gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Return-path: <stgt-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:message-id:from:to:cc:subject:in-reply-to:references
         :user-agent:mime-version:content-type;
        bh=oTZ320QU3s9nQQ32Ra8qapVdg3+iNQ8GKXpEhiftUiI=;
        b=egJZGpVZuB1HQWZT7uZI7X6CTIyIg6NZoGXeDRcEUE1R8/FMZ+SydYS9ft6uBqxhUx
         NiIBEvAQ28a+NZ1pNsqClLRr1QoDb2f5ntFQl9GCkOoguNwsgbqz56S0O7tfQqPja+sG
         BLdknLUAac4X6PnKzeIP8bh6f075k4U1mmhR27dbmT1Dx3pAK50uT7N7JJZjTnDmHi/G
         Am09zTbS7+y7OU5o5clod5Qh5lImsgvSTL7oJ4/No792yBG9p8knLVr9r6E8Jmehy7dD
         7RIuoT41bRZxidrs9MF13l5fr2IrR6HgPyoKdbksaIYxAveu8yLfHC0ei05HG5QghOFE
         yHPw==
In-Reply-To: <1381588740-25968-2-git-send-email-ronniesahlberg@gmail.com>
Sender: stgt-owner@vger.kernel.org
List-ID: <stgt.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: stgt@vger.kernel.org


Hi Ronnie,

At Sat, 12 Oct 2013 07:38:59 -0700,
Ronnie Sahlberg wrote:
> 
> While RDWR supports all SBC opcodes that TGTD implement SHEEPDOG
> only supports a subset and lacks the following opcodes:
>             WRITE_VERIFY10/12/16 VERIFY10/12/16 PREFETCH10/16
>             WRITE_SAME10/16 UNMAP and ORWRITE
> 
> This allows backends to specify which opcodes it is prepared to process
> and which commands should fail with invalid op code
> and allows SHEEPDOG backed LUNs to respond with INVALID_OP_CODE
> correctly.
> 
> This is most useful for block devices where we have several different backens
> and where some backends only support a subset of the commands
> 
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  usr/bs.c          |    8 ++++++++
>  usr/bs_rdwr.c     |   51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  usr/bs_sheepdog.c |   38 ++++++++++++++++++++++++++++++++++++++
>  usr/scsi.c        |    6 ++++++
>  usr/tgtd.h        |    1 +
>  5 files changed, 104 insertions(+), 0 deletions(-)
> 

Thanks a lot for the change! This patch looks good to me. I'll try to
implement these missing opcode in bs_sheepdog.c, but it will take time
and your solution is a great help.

Thanks,
Hitoshi