Re: [PATCH] nouveau_vieux: add AllocTextureImageBuffer implementation

From: Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] nouveau_vieux: add AllocTextureImageBuffer implementation
Date: Sun, 06 Oct 2013 13:31:28 -0700	[thread overview]
Message-ID: <87vc1ata3j.fsf@riseup.net> (raw)
In-Reply-To: <1380875338-25572-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>

[-- Attachment #1.1.1: Type: text/plain, Size: 1750 bytes --]

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> writes:

> This fixes issues where get_rt_format would see a 0 format because the
> nouveau_surface had not been properly initialized. Fixes crash on
> supertuxkart startup (which still fails due to out-of-vram issues).
>
> Signed-off-by: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>

Thanks, pushed.

>  src/mesa/drivers/dri/nouveau/nouveau_texture.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/nouveau/nouveau_texture.c b/src/mesa/drivers/dri/nouveau/nouveau_texture.c
> index da74e8f..8904389 100644
> --- a/src/mesa/drivers/dri/nouveau/nouveau_texture.c
> +++ b/src/mesa/drivers/dri/nouveau/nouveau_texture.c
> @@ -494,6 +494,14 @@ nouveau_compressed_teximage(struct gl_context *ctx, GLuint dims,
>  			 &ctx->Unpack, GL_TRUE);
>  }
>  
> +static GLboolean
> +nouveau_teximage_alloc(struct gl_context *ctx, struct gl_texture_image *ti)
> +{
> +	nouveau_teximage(ctx, 3, ti, 0, 0, 0, NULL,
> +			 &ctx->DefaultPacking, GL_FALSE);
> +	return GL_TRUE;
> +}
> +
>  static void
>  nouveau_texsubimage(struct gl_context *ctx, GLint dims,
>  		    struct gl_texture_image *ti,
> @@ -634,6 +642,7 @@ nouveau_texture_functions_init(struct dd_function_table *functions)
>  	functions->DeleteTexture = nouveau_texture_free;
>  	functions->NewTextureImage = nouveau_teximage_new;
>  	functions->FreeTextureImageBuffer = nouveau_teximage_free;
> +	functions->AllocTextureImageBuffer = nouveau_teximage_alloc;
>  	functions->ChooseTextureFormat = nouveau_choose_tex_format;
>  	functions->TexImage = nouveau_teximage_123d;
>  	functions->TexSubImage = nouveau_texsubimage_123d;
> -- 
> 1.8.1.5

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau