From: Namhyung Kim <namhyung@kernel.org>
To: Chenggang Qin <chenggang.qin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Chenggang Qin <chenggang.qcg@taobao.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Yanmin Zhang <yanmin.zhang@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Mike Galbraith <efault@gmx.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] perf core: Fix a mmap & munmap mismatches bug in dso__load
Date: Tue, 03 Sep 2013 18:02:24 +0900 [thread overview]
Message-ID: <87vc2ith0f.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1378049385-4466-2-git-send-email-chenggang.qin@gmail.com> (Chenggang Qin's message of "Sun, 1 Sep 2013 23:29:44 +0800")
On Sun, 1 Sep 2013 23:29:44 +0800, Chenggang Qin wrote:
> From: Chenggang Qin <chenggang.qcg@taobao.com>
>
> Some dsos' symsrc is neither syms_ss or runtime_ss. In this situation, the
> corresponding ELF file is opened and mmapped in symsrc__init(), but they will
> be not closed and munmapped in any place.
> This bug can lead to mmap & munmap mismatched, the mmap areas will exist during
> the life of perf. We can think this is a memory leak.
> This patch fixed the bug. symsrc__destroy() is called while the opened and
> mmaped ELF file has neither symtlb section nor dynsym section, and opdsec
> section.
> Thanks.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
next prev parent reply other threads:[~2013-09-03 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 15:29 [PATCH 1/3] perf core: Fix a mmap and munmap mismatched bug Chenggang Qin
2013-09-01 15:29 ` [PATCH 2/3] perf core: Fix a mmap & munmap mismatches bug in dso__load Chenggang Qin
2013-09-03 9:02 ` Namhyung Kim [this message]
2013-09-01 15:29 ` [PATCH 3/3] perf core: Fix a memory leak bug because symbol__delete is ignored Chenggang Qin
2013-09-03 9:02 ` Namhyung Kim
2013-09-03 9:01 ` [PATCH 1/3] perf core: Fix a mmap and munmap mismatched bug Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2013-10-11 0:27 Chenggang Qin
2013-10-11 0:27 ` [PATCH 2/3] perf core: Fix a mmap & munmap mismatches bug in dso__load Chenggang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc2ith0f.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=chenggang.qcg@taobao.com \
--cc=chenggang.qin@gmail.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.