From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 2/2] mmc: block: don't start new request when the card is removed Date: Mon, 11 Feb 2013 12:03:13 -0500 Message-ID: <87vc9yrdf2.fsf@octavius.laptop.org> References: <004801cdad17$498d9140$dca8b3c0$%jun@samsung.com> <201210191010.48776.heiko@sntech.de> <87liepq8qo.fsf@octavius.laptop.org> <201210292337.35620.heiko@sntech.de> <001e01cdf88d$f666ecb0$e334c610$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:41173 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757603Ab3BKRDT (ORCPT ); Mon, 11 Feb 2013 12:03:19 -0500 In-Reply-To: <001e01cdf88d$f666ecb0$e334c610$%jun@samsung.com> (Seungwon Jeon's message of "Tue, 22 Jan 2013 19:48:07 +0900") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: linux-mmc@vger.kernel.org, 'Sujit Reddy Thumma' , 'Adrian Hunter' Hi, On Tue, Jan 22 2013, Seungwon Jeon wrote: > Current request can be started newly while handling the error. > But if the card is removed, it's unnecessary to restart a request. > This makes the extra error handling. > > Signed-off-by: Seungwon Jeon > --- > drivers/mmc/card/block.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index f79b468..1170afe 100644 > --- a/drivers/mmc/card/block.c > +++ b/drivers/mmc/card/block.c > @@ -1456,8 +1456,14 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc) > > start_new_req: > if (rqc) { > - mmc_blk_rw_rq_prep(mq->mqrq_cur, card, 0, mq); > - mmc_start_req(card->host, &mq->mqrq_cur->mmc_active, NULL); > + if (mmc_card_removed(card)) { > + rqc->cmd_flags |= REQ_QUIET; > + blk_end_request_all(rqc, -EIO); > + } else { > + mmc_blk_rw_rq_prep(mq->mqrq_cur, card, 0, mq); > + mmc_start_req(card->host, > + &mq->mqrq_cur->mmc_active, NULL); > + } > } > > return 0; Thanks, pushed to mmc-next for 3.9. - Chris. -- Chris Ball One Laptop Per Child