diff for duplicates of <87vcarur8n.fsf@rustcorp.com.au> diff --git a/a/1.txt b/N1/1.txt index 642765d..4eed1f5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -84,8 +84,8 @@ index 2b1d517..c0bc9b9 100644 +again: + mutex_lock(&module_mutex); + if ((old = find_module_all(mod->name, true)) != NULL) { -+ if (old->state = MODULE_STATE_COMING -+ || old->state = MODULE_STATE_UNFORMED) { ++ if (old->state == MODULE_STATE_COMING ++ || old->state == MODULE_STATE_UNFORMED) { + /* Wait in case it fails to load. */ + mutex_unlock(&module_mutex); + err = wait_event_interruptible(module_wq, @@ -152,8 +152,8 @@ index 2b1d517..c0bc9b9 100644 -again: - mutex_lock(&module_mutex); - if ((old = find_module_all(mod->name, true)) != NULL) { -- if (old->state = MODULE_STATE_COMING -- || old->state = MODULE_STATE_UNFORMED) { +- if (old->state == MODULE_STATE_COMING +- || old->state == MODULE_STATE_UNFORMED) { - /* Wait in case it fails to load. */ - mutex_unlock(&module_mutex); - err = wait_event_interruptible(module_wq, diff --git a/a/content_digest b/N1/content_digest index 9a0e94d..72630a8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0CA+55aFzEkSOWL13cX2xaYttPF5=Qpvya9Yapk-RC8KQ5=QJk+w@mail.gmail.com\0" "From\0Rusty Russell <rusty@rustcorp.com.au>\0" "Subject\0Re: [patch] module: potential deadlock in error path\0" - "Date\0Mon, 21 Jan 2013 03:56:21 +0000\0" + "Date\0Mon, 21 Jan 2013 14:22:56 +1030\0" "To\0Linus Torvalds <torvalds@linux-foundation.org>\0" "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" Linux Kernel Mailing List <linux-kernel@vger.kernel.org> @@ -99,8 +99,8 @@ "+again:\n" "+\tmutex_lock(&module_mutex);\n" "+\tif ((old = find_module_all(mod->name, true)) != NULL) {\n" - "+\t\tif (old->state = MODULE_STATE_COMING\n" - "+\t\t || old->state = MODULE_STATE_UNFORMED) {\n" + "+\t\tif (old->state == MODULE_STATE_COMING\n" + "+\t\t || old->state == MODULE_STATE_UNFORMED) {\n" "+\t\t\t/* Wait in case it fails to load. */\n" "+\t\t\tmutex_unlock(&module_mutex);\n" "+\t\t\terr = wait_event_interruptible(module_wq,\n" @@ -167,8 +167,8 @@ "-again:\n" "-\tmutex_lock(&module_mutex);\n" "-\tif ((old = find_module_all(mod->name, true)) != NULL) {\n" - "-\t\tif (old->state = MODULE_STATE_COMING\n" - "-\t\t || old->state = MODULE_STATE_UNFORMED) {\n" + "-\t\tif (old->state == MODULE_STATE_COMING\n" + "-\t\t || old->state == MODULE_STATE_UNFORMED) {\n" "-\t\t\t/* Wait in case it fails to load. */\n" "-\t\t\tmutex_unlock(&module_mutex);\n" "-\t\t\terr = wait_event_interruptible(module_wq,\n" @@ -216,4 +216,4 @@ " \t/* Module is ready to execute: parsing args may do that. */\n" " \terr = parse_args(mod->name, mod->args, mod->kp, mod->num_kp," -fd2e3e72f282e4c93c33b396596e645de6ab450c75461fed4f6c12b3521fc07f +eb4d9ce9637ed535b3b97439ddf3824729e0f400a245ba02460f86b153140c29
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.