From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlxKC-0006v3-8h for qemu-devel@nongnu.org; Fri, 21 Dec 2012 02:47:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlxK7-0001aa-9z for qemu-devel@nongnu.org; Fri, 21 Dec 2012 02:47:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlxK7-0001aS-2v for qemu-devel@nongnu.org; Fri, 21 Dec 2012 02:47:15 -0500 From: Markus Armbruster References: <79b736d734e91b6c5b675b061fe9847e8bd24065.1356022464.git.jbaron@redhat.com> <20121220202639.GA29647@redhat.com> Date: Fri, 21 Dec 2012 08:47:09 +0100 In-Reply-To: <20121220202639.GA29647@redhat.com> (Jason Baron's message of "Thu, 20 Dec 2012 15:26:40 -0500") Message-ID: <87vcbv979e.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, Blue Swirl , andreas.faerber@web.de, pbonzini@redhat.com Jason Baron writes: > On Thu, Dec 20, 2012 at 08:07:02PM +0000, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron [...] >> > @@ -172,9 +173,11 @@ void qtest_quit(QTestState *s) >> > unlink(s->pid_file); >> > unlink(s->socket_path); >> > unlink(s->qmp_socket_path); >> > + unlink(s->tmp_dir); >> >> -EISDIR, rmdir() would be needed instead. >> > > 'unlink()' tested fine on Linux. But yes, it might not be as portable. s/might not be as/isn't/ SUSv7: [EPERM] The file named by path is a directory, and either the calling process does not have appropriate privileges, or the implementation prohibits using unlink() on directories. [...]