From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCVU-0002mK-Tg for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THCVR-0008LY-3T for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:43:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCVQ-0008LU-Rd for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:43:49 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RBhmls032539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 07:43:48 -0400 From: Markus Armbruster References: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com> Date: Thu, 27 Sep 2012 13:43:45 +0200 In-Reply-To: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Wed, 26 Sep 2012 17:25:35 -0300") Message-ID: <87vcezeln2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, avi@redhat.com Luiz Capitulino writes: > o v3 > > - doc & log fixups > - rename KeyCode.hex to KeyCode.number > > This actually fixes a regression introduced by the qapi conversion, > please refer to patch 2/3 for details. > > It's also important to note that this series changes the QMP > interface for the send-key command, but this shouldn't be a problem > as we're still in development phase. Reviewed-by: Markus Armbruster