All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Bernd Jendrissek <bernd.jendrissek@gmail.com>
Cc: Thomas Rast <trast@student.ethz.ch>, <git@vger.kernel.org>
Subject: Re: git diff vs git diff-files
Date: Tue, 14 Aug 2012 10:18:20 +0200	[thread overview]
Message-ID: <87vcgl999v.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <CAF7PVPqyaZQtca0KfWHirBY2Dvdtn2RT-_mxR8x5uUNsfbHmdQ@mail.gmail.com> (Bernd Jendrissek's message of "Mon, 13 Aug 2012 18:06:04 +0200")

Bernd Jendrissek <bernd.jendrissek@gmail.com> writes:

> On Mon, Aug 13, 2012 at 5:02 PM, Thomas Rast <trast@student.ethz.ch> wrote:
>> Can you share this repository?
>
> This weird behaviour doesn't even survive making a copy (cp -a) of the
> whole repository, so I very much doubt making it available would be
> illuminative. My disk's SMART data seems okay. The weird-quotient just
> rose a bit.

That sounds like an issue with stat() data, and then it doesn't.  cp -a
would change all the inode numbers, triggering a full refresh of the
index in 'git diff'.  But I'm not sure exactly how this can lead to
disagreement, since both commands read *both* index and worktree version
of the file.  Very confusing.

Can you try the following:

  git ls-files --debug gnetlist/tests/common/outputs/osmond/TwoStageAmp-output.net
  cp .git/index .git/index.orig
  touch gnetlist/tests/common/outputs/osmond/TwoStageAmp-output.net
  # note, it is important that you run diff first
  git diff gnetlist/tests/common/outputs/osmond/TwoStageAmp-output.net
  git diff-files -p gnetlist/tests/common/outputs/osmond/TwoStageAmp-output.net
  git ls-files --debug gnetlist/tests/common/outputs/osmond/TwoStageAmp-output.net

>> Or at least the pre- and post-change
>> files, transferred in such a way that there won't be any whitespace
>> damage (your snippets above show obvious damage).  You can use
>
> http://www.bpj-code.co.za/downloads.php/bugs/TwoStageAmp-output.net?text
> contains the output from git show a5ee1e7. Leave off the ?text for an
> application/octet-stream download.

Umm, that's only one side of the diff, isn't it?  The hunk header claims
that the hunk goes up to line 47, so there must be more changes beyond
what you showed.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-08-14  8:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13  8:55 git diff vs git diff-files Bernd Jendrissek
2012-08-13 15:02 ` Thomas Rast
2012-08-13 16:06   ` Bernd Jendrissek
2012-08-14  8:18     ` Thomas Rast [this message]
2012-08-14  9:15       ` Bernd Jendrissek
2012-08-14  9:55         ` Thomas Rast
2012-08-14 11:09           ` Andreas Schwab
2012-08-14 13:11           ` Bernd Jendrissek
2012-08-13 15:13 ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcgl999v.fsf@thomas.inf.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=bernd.jendrissek@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.