All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Barbaros Tokaoğlu" <barbarost@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set
Date: Mon, 06 Aug 2012 10:00:52 +0930	[thread overview]
Message-ID: <87vcgwzwsj.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAL7r9b39L1HuKis+PxOh9tAJ0iEwsP2c+k+=6w00JWCa=FwW5w@mail.gmail.com>

On Wed, 1 Aug 2012 20:57:07 +0300, Barbaros Tokaoğlu <barbarost@gmail.com> wrote:
> ref_module function is not defined when CONFIG_MODULES is not set thus
> it causes compile error when a module which is set to be built-in uses it.
> This patch defines a dummy ref_module function when CONFIG_MODULES
> is not set.
> 
> Signed-off-by: Barbaros Tokaoğlu <barbarost@gmail.com>

Hi Barbaros,

        It's usually a good idea to paste the error message into the
commit message for compile fixes: it helps people googling the problem.

In this case, it's particularly important, because I can't find any
users of ref_module() outside module.c itself: it's only exported for
ksplice to use.

Cheers,
Rusty.

  reply	other threads:[~2012-08-06  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 17:57 [PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set Barbaros Tokaoğlu
2012-08-06  0:30 ` Rusty Russell [this message]
2012-08-06 14:57   ` Barbaros Tokaoğlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcgwzwsj.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=barbarost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.