All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] new package: bellagio
Date: Sun, 29 Apr 2012 12:42:05 +0200	[thread overview]
Message-ID: <87vcki6cqq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1335286281-8642-1-git-send-email-qais.yousef@imgtec.com> (Qais Yousef's message of "Tue, 24 Apr 2012 17:51:21 +0100")

>>>>> "Qais" == Qais Yousef <qais.yousef@imgtec.com> writes:

 Qais> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
 Qais> ---

 Qais> I haven't seen the v1 committed, so I am sending v2 here which
 Qais> includes the following additions:

 Qais> 	- Add a patch to fix a runtime error when using dynamicloader.
 Qais> 	- Add a patch to fix when building in parallel.
 Qais> 	- Set AUTORECONF to YES as we modify the Makefile.am

 Qais> All patches have been sent to relevant upstream mailing list.

 Qais> Hope this looks alright! :-)

 Qais> diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
 Qais> index a05d1d9..7e18bcb 100644
 Qais> --- a/package/multimedia/Config.in
 Qais> +++ b/package/multimedia/Config.in
 Qais> @@ -2,6 +2,7 @@ menu "Audio and video libraries and applications"
 Qais>  source "package/multimedia/alsa-lib/Config.in"
 Qais>  source "package/multimedia/alsa-utils/Config.in"
 Qais>  source "package/multimedia/aumix/Config.in"
 Qais> +source "package/multimedia/bellagio/Config.in"
 Qais>  source "package/multimedia/faad2/Config.in"
 Qais>  source "package/multimedia/flac/Config.in"
 Qais>  source "package/multimedia/ffmpeg/Config.in"
 Qais> diff --git a/package/multimedia/bellagio/Config.in b/package/multimedia/bellagio/Config.in
 Qais> new file mode 100644
 Qais> index 0000000..907709f
 Qais> --- /dev/null
 Qais> +++ b/package/multimedia/bellagio/Config.in
 Qais> @@ -0,0 +1,14 @@
 Qais> +config BR2_PACKAGE_BELLAGIO
 Qais> +	bool "bellagio"
 Qais> +	help
 Qais> +	  Bellagio is an opensource implementation of the
 Qais> +	  OpenMAX IL API.

Bellagio is implemented in C++, so you need to add 'depends on
BR2_INSTALL_LIBSTDCPP'. The configure script also unconditionally adds
-Wall -Werror to CFLAGS, easily breaking the build.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2012-04-29 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 16:51 [Buildroot] [PATCH v2] new package: bellagio Qais Yousef
2012-04-27 20:43 ` Arnout Vandecappelle
2012-04-29 10:42 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcki6cqq.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.