From: Michael D Labriola <michael.d.labriola@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Matthew Garrett <mjg@redhat.com>,
Michael D Labriola <mlabriol@gdeb.com>,
Kushal Koolwal <kushalkoolwal@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86, reboot: remove VersaLogic Menlow reboot quirk
Date: Sun, 29 Jan 2012 14:21:17 -0500 [thread overview]
Message-ID: <87vcnub9hu.fsf@gmail.com> (raw)
This commit removes the reboot quirk originally added by commit e19e074
(x86: Fix reboot problem on VersaLogic Menlow boards).
Testing with a VersaLogic Ocelot (VL-EPMs-21a rev 1.00 w/ BIOS 6.5.102)
revealed the following regarding the reboot hang problem:
- v2.6.37 reboot=bios was needed.
- v2.6.38-rc1: behavior changed, reboot=acpi is needed, reboot=kbd and
reboot=bios result in system hang.
- v2.6.38: VersaLogic patch (e19e074 x86: Fix reboot problem on
VersaLogic Menlow boards) was applied prior to v2.6.38-rc7. This
patch sets a quirk for VersaLogic Menlow boards that forces the use
of reboot=bios, which doesn't work anymore.
- v3.2: It seems that commit 660e34c (x86: Reorder reboot method
preferences) changed the default reboot method to acpi prior to
v3.0-rc1, which means the default behavior is appropriate for the
Ocelot. No VersaLogic quirk is required.
The Ocelot board used for testing can successfully reboot w/out having to
pass any reboot= arguments for all 3 current versions of the BIOS.
Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
---
arch/x86/kernel/reboot.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index b257f0e..d840e69 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -309,14 +309,6 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "P4S800"),
},
},
- { /* Handle problems with rebooting on VersaLogic Menlow boards */
- .callback = set_bios_reboot,
- .ident = "VersaLogic Menlow based board",
- .matches = {
- DMI_MATCH(DMI_BOARD_VENDOR, "VersaLogic Corporation"),
- DMI_MATCH(DMI_BOARD_NAME, "VersaLogic Menlow board"),
- },
- },
{ /* Handle reboot issue on Acer Aspire one */
.callback = set_kbd_reboot,
.ident = "Acer Aspire One A110",
--
1.7.1.1
next reply other threads:[~2012-01-29 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 19:21 Michael D Labriola [this message]
2012-01-30 13:22 ` [tip:x86/urgent] x86/reboot: Remove VersaLogic Menlow reboot quirk tip-bot for Michael D Labriola
-- strict thread matches above, loose matches on Subject: below --
2012-01-17 15:16 [PATCH] x86, reboot: remove " Michael D Labriola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcnub9hu.fsf@gmail.com \
--to=michael.d.labriola@gmail.com \
--cc=kushalkoolwal@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=mlabriol@gdeb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.