From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 14/22] OMAP2+: voltage: split voltage controller (VC) code into dedicated layer Date: Fri, 09 Sep 2011 14:51:40 -0700 Message-ID: <87vct1s7tf.fsf@ti.com> References: <1314639355-12713-1-git-send-email-khilman@ti.com> <1314639355-12713-15-git-send-email-khilman@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: (Jean Pihet's message of "Wed, 7 Sep 2011 12:42:20 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jean Pihet Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org SmVhbiBQaWhldCA8amVhbi5waWhldEBuZXdvbGRiaXRzLmNvbT4gd3JpdGVzOgoKPiBLZXZpbiwK Pgo+IE9uIE1vbiwgQXVnIDI5LCAyMDExIGF0IDc6MzUgUE0sIEtldmluIEhpbG1hbiA8a2hpbG1h bkB0aS5jb20+IHdyb3RlOgo+PiBBcyBwYXJ0IG9mIHRoZSB2b2x0YWdlIGxheWVyIGNsZWFudXAs IHNwbGl0IG91dCBWQyBzcGVjaWZpYyBjb2RlIGludG8KPj4gYSBkZWRpY2F0ZWQgVkMgbGF5ZXIu IMKgVGhpcyBwYXRjaCBwcmltYXJpbHkganVzdCBtb3ZlcyBWQyBjb2RlIGZyb20KPj4gdm9sdGFn ZS5jIGludG8gdmMuYywgYW5kIGFkZHMgcHJvdG90eXBlcyB0byB2Yy5oLgo+Pgo+PiBObyBmdW5j dGlvbmFsIGNoYW5nZXMuCj4+Cj4+IEZvciByZWFkYWJpbGl0eSwgZWFjaCBmdW5jdGlvbiB3YXMg Z2l2ZW4gYSBsb2NhbCAndmMnIHBvaW50ZXI6Cj4+Cj4+IMKgIMKgc3RydWN0IG9tYXBfdmNfaW5z dGFuY2VfZGF0YSAqdmMgPSB2b2x0ZG0tPnZkZC0+dmNfZGF0YTsKPj4KPj4gYW5kIGEgZ2xvYmFs IHJlcGxhY2Ugb2Ygcy92ZGQtPnZjX2RhdGEvdmMvIHdhcyBkb25lLgo+Pgo+PiBBbHNvIHZjX2lu aXQgd2FzIHJlbmFtZWQgdG8gdmNfaW5pdF9jaGFubmVsIHRvIHJlZmxlY3QgdGhhdCB0aGlzIGlz Cj4+IHBlci1WQyBjaGFubmVsIGluaXRpYWxpenRpb24uCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEtl dmluIEhpbG1hbiA8a2hpbG1hbkB0aS5jb20+Cj4+IC0tLQo+PiDCoGFyY2gvYXJtL21hY2gtb21h cDIvTWFrZWZpbGUgwqB8IMKgIMKgMiArLQo+PiDCoGFyY2gvYXJtL21hY2gtb21hcDIvdmMuYyDC oCDCoCDCoHwgwqAyNzYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK Pj4gwqBhcmNoL2FybS9tYWNoLW9tYXAyL3ZjLmggwqAgwqAgwqB8IMKgIDEyICsrCj4+IMKgYXJj aC9hcm0vbWFjaC1vbWFwMi92b2x0YWdlLmMgfCDCoDI2NCArLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KPj4gwqA0IGZpbGVzIGNoYW5nZWQsIDI5MyBpbnNlcnRpb25zKCsp LCAyNjEgZGVsZXRpb25zKC0pCj4+IMKgY3JlYXRlIG1vZGUgMTAwNjQ0IGFyY2gvYXJtL21hY2gt b21hcDIvdmMuYwo+Pgo+IC4uLgo+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLW9tYXAy L3ZjLmMgYi9hcmNoL2FybS9tYWNoLW9tYXAyL3ZjLmMKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQK Pj4gaW5kZXggMDAwMDAwMC4uOThmNWE0Ygo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBiL2FyY2gv YXJtL21hY2gtb21hcDIvdmMuYwo+PiBAQCAtMCwwICsxLDI3NiBAQAo+Cj4gVGhlIGNvcHlyaWdo dCBub3RpY2UgaXMgbWlzc2luZy4KPgoKb29wcywgd2lsbCBhZGQuCgpUaGFua3MsCgpLZXZpbgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 09 Sep 2011 14:51:40 -0700 Subject: [PATCH 14/22] OMAP2+: voltage: split voltage controller (VC) code into dedicated layer In-Reply-To: (Jean Pihet's message of "Wed, 7 Sep 2011 12:42:20 +0200") References: <1314639355-12713-1-git-send-email-khilman@ti.com> <1314639355-12713-15-git-send-email-khilman@ti.com> Message-ID: <87vct1s7tf.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jean Pihet writes: > Kevin, > > On Mon, Aug 29, 2011 at 7:35 PM, Kevin Hilman wrote: >> As part of the voltage layer cleanup, split out VC specific code into >> a dedicated VC layer. ?This patch primarily just moves VC code from >> voltage.c into vc.c, and adds prototypes to vc.h. >> >> No functional changes. >> >> For readability, each function was given a local 'vc' pointer: >> >> ? ?struct omap_vc_instance_data *vc = voltdm->vdd->vc_data; >> >> and a global replace of s/vdd->vc_data/vc/ was done. >> >> Also vc_init was renamed to vc_init_channel to reflect that this is >> per-VC channel initializtion. >> >> Signed-off-by: Kevin Hilman >> --- >> ?arch/arm/mach-omap2/Makefile ?| ? ?2 +- >> ?arch/arm/mach-omap2/vc.c ? ? ?| ?276 +++++++++++++++++++++++++++++++++++++++++ >> ?arch/arm/mach-omap2/vc.h ? ? ?| ? 12 ++ >> ?arch/arm/mach-omap2/voltage.c | ?264 +-------------------------------------- >> ?4 files changed, 293 insertions(+), 261 deletions(-) >> ?create mode 100644 arch/arm/mach-omap2/vc.c >> > ... > >> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c >> new file mode 100644 >> index 0000000..98f5a4b >> --- /dev/null >> +++ b/arch/arm/mach-omap2/vc.c >> @@ -0,0 +1,276 @@ > > The copyright notice is missing. > oops, will add. Thanks, Kevin