All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Antti Palosaari <crope@iki.fi>
Cc: Steve Kerrison <steve@stevekerrison.com>, linux-media@vger.kernel.org
Subject: [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency
Date: Wed, 01 Jun 2011 11:45:27 +0200	[thread overview]
Message-ID: <87vcwpnavc.fsf@nemi.mork.no> (raw)

Hello,

I noticed this warning 

    WARNING: "cxd2820r_get_tuner_i2c_adapter" [/usr/local/src/git/linux-2.6/drivers/media/video/em28xx/em28xx-dvb.ko] undefined!

while building the driver in 2.6.32 with backported 290e support.  This
warning does not appear with 3.0.0-rc1, but the call still does cause a
hard dependency on cxd2820r even if you build with CONFIG_MEDIA_ATTACH=y:

bjorn@canardo:/usr/local/src/git/linux-2.6$ modinfo drivers/media/video/em28xx/em28xx-dvb.ko
filename:       drivers/media/video/em28xx/em28xx-dvb.ko
license:        GPL
author:         Mauro Carvalho Chehab <mchehab@infradead.org>
description:    driver for em28xx based DVB cards
depends:        cxd2820r,dvb-core,em28xx,usbcore
vermagic:       3.0.0-rc1+ SMP mod_unload modversions 
parm:           debug:enable debug messages [dvb] (int)
parm:           adapter_nr:DVB adapter numbers (array of short)

I assume this is unwanted.  As you can see, cxd2820r is the only
frontend dependency....

Don't know the proper fix.  My naïve quick-fix was just to move struct
cxd2820r_priv into cxd2820r.h and making the function static inlined.
However, I do see that you may not want the struct in cxd2820r.h.  But I
trust that you have a brilliant solution to the problem :-)

Thanks for your great work on the cxd2820r driver and nanostick T2 290e
support!



Bjørn

             reply	other threads:[~2011-06-01 10:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01  9:45 Bjørn Mork [this message]
2011-06-01  9:49 ` [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency Antti Palosaari
2011-06-01 10:31   ` Bjørn Mork
2011-06-01 10:53   ` Bjørn Mork
2011-06-01 17:18     ` Bjørn Mork
2011-06-03 12:21       ` Antti Palosaari
2011-06-03 12:50         ` Bjørn Mork
2011-06-03 12:59           ` Antti Palosaari
2011-06-03 13:20             ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcwpnavc.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=steve@stevekerrison.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.