From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: nmi is broken? Date: Sun, 24 Apr 2011 20:13:15 +0900 Message-ID: <87vcy3zyus.fsf@devron.myhome.or.jp> References: <87sjtbe7fz.fsf@devron.myhome.or.jp> <877hak1t1s.fsf@devron.myhome.or.jp> <4DB3C6D3.9040703@redhat.com> <87zkngypn8.fsf@devron.myhome.or.jp> <4DB3F182.3070006@web.de> Mime-Version: 1.0 Content-Type: text/plain Cc: Avi Kivity , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mail.parknet.co.jp ([210.171.160.6]:33263 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756551Ab1DXLNT (ORCPT ); Sun, 24 Apr 2011 07:13:19 -0400 In-Reply-To: <4DB3F182.3070006@web.de> (Jan Kiszka's message of "Sun, 24 Apr 2011 11:46:42 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka writes: >> Yes, this is old kernel (2.6.9), and is not using HPET >> (CONFIG_HPET_TIMER=n), using IO-APIC as NMI source (PMU seems to be >> unsupported on kvm for now). >> >> Unfortunately, -no-hpet didn't change situation. irq_stat.apic_timer_irqs >> and nmi_count() are same while irq is disabled. > > Maybe it's a regression of latest NMI injection patches. > > This worked before? Can you check if commits > c2dd554dc61173ecb6b3741b680d2ae4c245d2ba and > f86368493ec038218e8663cc1b6e5393cd8e008a have any impact on your problem? Unfortunately, no. I've checked kvm_inject_nmi() was not called if irq was disabled on guest. The path is following (without my patch, kvm_apic_nmi_wd_deliver is not called), pit_do_work() kvm_apic_nmi_wd_deliver() kvm_apic_local_deliver() __apic_accept_irq() kvm_inject_nmi() so it is not meaningful to change after kvm_inject_nmi() (if I'm understanding commits correctly). Thanks. -- OGAWA Hirofumi