From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 26/29] drm/i915: Invert watermarks used for
	i8xx, i9xx.
Date: Mon, 30 Aug 2010 15:39:10 -0700
Message-ID: <87vd6r20a9.fsf@pollan.anholt.net>
References: <1282475148-15951-1-git-send-email-chris@chris-wilson.co.uk>
	<1282475148-15951-27-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1195751985=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1282475148-15951-27-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1195751985==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sun, 22 Aug 2010 12:05:45 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:
> The calculation seem backwards as they compute the number of entries
> that would be drained during a memory fetch, and but return the opposite
> value.
>=20
> This fixes a common flicker [or even completely scrambled display] on
> high resolution outputs (e.g. 1920x1080 with 915GM). However, as we do not
> adjust DSPARB, we are still limited by the FIFO setup by the BIOS which m=
ay
> continue to cause underruns with high resolutions on some machines.
>=20
> References:
>=20
>   Bug 22996 - [945GM] external lcd does not work on high resolution
>   https://bugs.freedesktop.org/show_bug.cgi?id=3D22996
>=20
>   Bug 25284 - [915GM] random flickering when using metacity-compositor
>   https://bugs.freedesktop.org/show_bug.cgi?id=3D25284
>=20
>   Bug 25857 - [945]: Entire screen "jerks" randomly after removing extern=
al monitor
>   https://bugs.freedesktop.org/show_bug.cgi?id=3D25857
>=20
>   Bug 27738 - [915] 1920x1200 resolution fails, probable FIFO issue.
>   https://bugs.freedesktop.org/show_bug.cgi?id=3D27738
>=20
>   Bug 28149 - [945GM] KMS regression.
>   https://bugs.freedesktop.org/show_bug.cgi?id=3D28149
>=20
> Also it may address some instances where the monitor fails to sync
> due to underruns.

What's up with all the bug references here?  I hit the first 3 and
didn't see any mention of this patch.  I'd probably prefer to see either
Tested-by or nothing.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkx8Mw4ACgkQHUdvYGzw6vc+tACeKP4ObcEIxYXZoEYWKdrjezqK
+yIAmgK4bAniGfM0WpmWMB7enZwm0ZFP
=qxa4
-----END PGP SIGNATURE-----
--=-=-=--

--===============1195751985==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1195751985==--