From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PXA: Fix wakealarm capability for pxa-rtc
Date: Sun, 01 Aug 2010 21:32:47 +0200 [thread overview]
Message-ID: <87vd7uxh5s.fsf@free.fr> (raw)
In-Reply-To: <201008011738.16225.marek.vasut@gmail.com> (Marek Vasut's message of "Sun\, 1 Aug 2010 17\:38\:16 +0200")
Marek Vasut <marek.vasut@gmail.com> writes:
>> Okay, I understand better, you're looking for the class driver wakup sysfs
>> entry, and not the driver sysfs wakeup entry.
>>
>> So when you said "It's not created for me without this patch", you meant
>> the class driver's sysfs entry, not the one I mentioned I presume ?
>
> You're still talking about some "wakeup", I'm talking about
> /sys/devices/platform/pxa-rtc/power/wakealarm .
...
>>
>> Anyway, to straighten things up :
>> - for an rtc driver, device_init_wakeup() has to be called before
>> rtc_driver_register()
>> - if that's not the case, /sys/class/rtc/rtc0/wakealarm won't be created
>> - if that's the case, if the driver called device_init_wakeup(x, 1), the
>> rtc registering will override the value with device_init_wakeup(x, 0)
>
> Are we talking about the same kernel? I just can't find this
> "device_init_wakeup(x, 0);" which would override anything anywhere.
I already provided the call tree.
Anyway, I won't be available for the next days, and as I don't want to argue
anymore, and I expect you have tested your patch against a suspended device to
see it wake up, have my:
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
next prev parent reply other threads:[~2010-08-01 19:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 4:22 [PATCH] PXA: Fix wakealarm capability for pxa-rtc Marek Vasut
2010-07-31 15:38 ` Robert Jarzmik
2010-07-31 20:15 ` Marek Vasut
2010-07-31 21:07 ` Robert Jarzmik
2010-08-01 0:13 ` Marek Vasut
2010-08-01 0:48 ` Robert Jarzmik
2010-08-01 0:53 ` Marek Vasut
2010-08-01 11:15 ` Robert Jarzmik
2010-08-01 15:38 ` Marek Vasut
2010-08-01 19:32 ` Robert Jarzmik [this message]
2010-08-03 0:03 ` Alessandro Zummo
2010-08-03 3:10 ` Marek Vasut
2010-08-06 19:59 ` Alessandro Zummo
2010-08-06 21:39 ` Marek Vasut
2010-08-07 9:43 ` Robert Jarzmik
2010-08-18 4:08 ` Eric Miao
2010-08-18 5:04 ` Marek Vasut
2010-08-18 6:15 ` Eric Miao
2010-08-01 8:42 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd7uxh5s.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.