Re: [pm-wip/uart][PATCH 3/4] Serial: Avoid using hwmod lookup using name string

[Kevin Hilman <khilman@deeprootsystems.com>]

"Gopinath, Thara" <thara@ti.com> writes:

>>>
>>>-		uart = kzalloc(sizeof(struct omap_uart_state), GFP_KERNEL);
>>>-		if (WARN_ON(!uart))
>>>-			return;
>>>+	/*
>>>+	 * NOTE: omap_hwmod_init() has not yet been called,
>>>+	 *       so no hwmod functions will work yet.
>>>+	 */
>>>
>>>-		uart->oh = oh;
>>>-		uart->num = i++;
>>>-		list_add_tail(&uart->node, &uart_list);
>>>-		num_uarts++;
>>>+	/*
>>>+	 * During UART early init, device need to be probed
>>>+	 * to determine SoC specific init before omap_device
>>>+	 * is ready.  Therefore, don't allow idle here
>>>+	 */
>
> You have two comment blocks back to back. Either make it into one block or put the first block appropriately above the intended code.

The latter please.

Kevin