Re: [PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[Kevin Hilman <khilman@deeprootsystems.com>]

Ajay Kumar Gupta <ajay.gupta@ti.com> writes:

> MUSB interface on AM35x stops working when we set AUTOIDLE bit (D0) in
> CONTROL_SYSCONFIG(0x48002010) register.

why?

stops working in what way?

I think you need to investigate more into why this is happening.

This suggest to me that something in the MUSB device/driver init
is not quite right for these boards.  

Kevin


> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index ea0000b..cc9d566 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -849,7 +849,12 @@ static void __init prcm_setup_regs(void)
>  			CM_AUTOIDLE);
>  	}
>  
> -	omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> +	/*
> +	 * MUSB interface on AM35x stops working when we enable AUTOIDLE,
> +	 * so avoid this for AM3517 and AM3505 device.
> +	 */
> +	if (!cpu_is_omap3517() && !cpu_is_omap3505())
> +		omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
>  
>  	/*
>  	 * Set all plls to autoidle. This is needed until autoidle is
> -- 
> 1.6.2.4