From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Arce, Abraham" <x0066660@ti.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
Date: Tue, 20 Apr 2010 16:16:00 -0700 [thread overview]
Message-ID: <87vdblbtqn.fsf@deeprootsystems.com> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A53043D9EE7F5@dlee03.ent.ti.com> (Abraham Arce's message of "Tue\, 13 Apr 2010 20\:10\:48 -0500")
"Arce, Abraham" <x0066660@ti.com> writes:
> Keyboard controller for OMAP4 with built-in scanning algorithm.
> The following implementations are used:
>
> - matrix_keypac.c logic
> - hwmod framework
> - threaded irq
>
> Signed-off-by: Syed Rafiuddin <rafiuddin.syed@ti.com>
> Signed-off-by: Abraham Arce <x0066660@ti.com>
Some general comments...
What's missing here is a separation of the driver and the device.
What you need is for arch code to register a platfrom_device (using
hwmod + omap_device). Then this driver will use the standard
platform_device resource calls to get its base address, IRQs, etc. and
any platform_data.
IOW, as Felipe mentioned, the driver should not be doing the hwmod +
omap_device init and registration.
Kevin
next prev parent reply other threads:[~2010-04-20 23:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 1:10 [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support Arce, Abraham
2010-04-14 7:34 ` Trilok Soni
2010-04-16 0:04 ` Arce, Abraham
2010-04-20 23:11 ` Kevin Hilman
2010-04-16 5:06 ` Felipe Balbi
2010-05-05 23:17 ` Arce, Abraham
2010-04-20 23:16 ` Kevin Hilman [this message]
2010-05-06 2:30 ` Arce, Abraham
2010-04-21 6:55 ` Dmitry Torokhov
2010-05-11 4:13 ` Arce, Abraham
2010-05-11 4:17 ` Arce, Abraham
2010-05-11 4:41 ` Dmitry Torokhov
2010-05-11 5:03 ` Arce, Abraham
2010-05-11 5:45 ` Dmitry Torokhov
2010-05-11 14:53 ` Kevin Hilman
2010-05-11 16:41 ` Dmitry Torokhov
2010-05-11 21:39 ` Kevin Hilman
2010-05-12 5:34 ` Shilimkar, Santosh
2010-05-12 5:40 ` Arce, Abraham
2010-05-12 5:45 ` Shilimkar, Santosh
2010-05-12 6:03 ` Dmitry Torokhov
2010-05-12 6:19 ` Shilimkar, Santosh
2010-05-12 6:35 ` Dmitry Torokhov
2010-05-12 6:54 ` Shilimkar, Santosh
2010-05-12 6:20 ` Arce, Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdblbtqn.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.