From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] sed: fix compilation with external toolchains
Date: Tue, 04 Aug 2009 22:57:33 +0200 [thread overview]
Message-ID: <87vdl3pa9u.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <6ce736a58c8973ceba56bc95f11118b7c1351f11.1249415132.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue\, 4 Aug 2009 21\:48\:00 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Since CC is already passed in TARGET_CONFIGURE_OPTS at ./configure
Thomas> time, there's no point in overriding it with a wrong value at
Thomas> compilation time. This breaks external toolchain builds since
Thomas> CC=$(TARGET_CC) is wrong because it excludes the mandatory --sysroot
Thomas> option.
Thomas> Fixes bug #525
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> CHANGES | 1 +
Thomas> package/sed/sed.mk | 2 +-
Thomas> 2 files changed, 2 insertions(+), 1 deletions(-)
Thomas> diff --git a/CHANGES b/CHANGES
Thomas> index 0c1f667..36b9b45 100644
Thomas> --- a/CHANGES
Thomas> +++ b/CHANGES
Thomas> @@ -77,6 +77,7 @@
Thomas> #497: OpenSSL RSA key generation hangs on x86_64
Thomas> #509: Bump sqlite package to 3.6.16
Thomas> #523: pciutils broken with external toolchain
Thomas> + #525: sed broken with external toolchain
This should preferably go after -rc1, but I'll fix that for you.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-08-04 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 19:47 [Buildroot] [pull request] Pull request for branch sed-fix Thomas Petazzoni
2009-08-04 19:48 ` [Buildroot] [PATCH 1/1] sed: fix compilation with external toolchains Thomas Petazzoni
2009-08-04 20:57 ` Peter Korsgaard [this message]
2009-08-04 22:07 ` Thomas Petazzoni
2009-08-04 20:59 ` [Buildroot] [pull request] Pull request for branch sed-fix Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdl3pa9u.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.