From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
Alexey Dobriyan
<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Add AF_INET c/r support
Date: Wed, 01 Jul 2009 09:10:07 -0700 [thread overview]
Message-ID: <87vdmcxu3k.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <4A42EA32.4070809-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> (Oren Laadan's message of "Wed\, 24 Jun 2009 23\:08\:34 -0400")
OL> Adding a comment about it would clearly show that you thought
OL> about it, and warn others.
Done.
OL> Network developers are probably the right audience for this kind
OL> of audit.
Yep, agreed. I suppose I'll copy netdev on the next round unless
there are more comments...
OL> Relocating the function below generates confusing noise in the
OL> patch.
Yep, and made for a bunch of collisions when changing the UNIX patch
underneath. Sorry about that.
OL> What about sockets that aren't either TCP_{LISTEN,ESTABLISHED} ?
Yep, I caused it to fail to restart with an unconnected UDP socket.
I've got that fixed up now.
Thanks!
--
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
next prev parent reply other threads:[~2009-07-01 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 19:12 [PATCH] Add AF_INET c/r support Dan Smith
[not found] ` <1245697976-29159-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-23 14:53 ` Serge E. Hallyn
[not found] ` <20090623145313.GA19332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-23 15:12 ` Dan Smith
[not found] ` <87ocsfyoey.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-06-23 16:14 ` Serge E. Hallyn
[not found] ` <20090623161406.GA21423-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-23 17:03 ` Serge E. Hallyn
2009-06-25 3:08 ` Oren Laadan
[not found] ` <4A42EA32.4070809-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-07-01 16:10 ` Dan Smith [this message]
2009-06-26 22:09 ` Matt Helsley
[not found] ` <20090626220906.GF17502-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-01 16:11 ` Dan Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdmcxu3k.fsf@caffeine.danplanet.com \
--to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.