From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLdYP-0007Yq-6f
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:39:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLdYI-0007U5-GM
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:39:18 -0400
Received: from [199.232.76.173] (port=37308 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLdYI-0007Tv-5T
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:39:14 -0400
Received: from mx2.redhat.com ([66.187.237.31]:37780)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MLdYH-0000ux-Nt
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:39:14 -0400
Subject: Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.
References: <1246286263-27970-1-git-send-email-kraxel@redhat.com>
	<200906301216.41794.paul@codesourcery.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 30 Jun 2009 15:37:09 +0200
In-Reply-To: <200906301216.41794.paul@codesourcery.com> (Paul Brook's message
	of "Tue\, 30 Jun 2009 12\:16\:40 +0100")
Message-ID: <87vdmdalmi.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Paul Brook <paul@codesourcery.com> writes:

> On Monday 29 June 2009, Gerd Hoffmann wrote:
>> Here is a patch adding a generic -pcidevice command line switch.
>
> This sort of feature is one of the reasons I object to "partial" qdev 
> conversions. A partially converted device will break in unfriendly ways when 
> you try to instantiate it via this option or a machine config file.
>
> Paul

I don't think these are sensible reasons to block progress on qdev
conversions.

The machine config file does not exist, and won't be useful until the
devices are converted to qdev.

-pcidevice can be useful now, for devices converted to qdev, but it
doesn't fully work for certain incomplete conversions.  While that's
inacceptable for a release, is it really so horrible as a transient step
now?  Besides, we can easily flag incompletely converted devices, and
make -pcidevice not touch them.