From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option
Date: Mon, 15 Jun 2009 13:04:09 +0200 [thread overview]
Message-ID: <87vdmx69na.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <4A36138C.4060306@redhat.com> (Dor Laor's message of "Mon\, 15 Jun 2009 12\:25\:32 +0300")
Dor Laor <dlaor@redhat.com> writes:
> Gerd Hoffmann wrote:
>>>
>>> This new option may be used to disable the virtio-balloon device.
>>>
>>
>> ACK, looks good.
>>
>> And I can drop my lazy patch which just comments out virtio-balloon
>> in the code ;)
>
> Actually, I rather have the balloon disabled by default. It's like any
> other pci device which needs
> explicit command line specification. Why consume a pci slot if not
> implicitly required?
I agree. The command line is plenty magic without implicitly added
PCI devices.
Besides, negative options -no-virtio-balloon lead to ugly
double-negatives like if (!no_virtio_balloon).
next prev parent reply other threads:[~2009-06-15 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 19:23 [Qemu-devel] [PATCH] Add -no-virtio-balloon command-line option Eduardo Habkost
2009-06-10 19:25 ` [Qemu-devel] " Anthony Liguori
2009-06-10 19:34 ` Eduardo Habkost
2009-06-11 10:07 ` Gerd Hoffmann
2009-06-15 9:25 ` Dor Laor
2009-06-15 11:04 ` Markus Armbruster [this message]
2009-06-15 12:54 ` Anthony Liguori
2009-06-15 13:40 ` Dor Laor
2009-06-15 13:46 ` Anthony Liguori
2009-06-15 18:07 ` Markus Armbruster
2009-06-15 18:14 ` Anthony Liguori
2009-06-26 17:15 ` [Qemu-devel] [PATCH] Replace -no-virtio-balloon by -balloon Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdmx69na.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.